pg_dump: Remove dead code in TAP tests

The schema_only_with_statistics test scenario was referenced in
002_pg_dump.pl, but was associated to no command sequence since
0ed92cf50cc4.

Issue discovered while investigating a different bug.  Perhaps this
cleanup is not worth backpatching, but there is also an argument in
favor of reducing noise when touching this area of the code in stable
branches.

Reviewed-by: Ewan Young <kdbase.hack@gmail.com>
Reviewed-by: Ayush Tiwari <ayushtiwari.slg01@gmail.com>
Discussion: https://postgr.es/m/ai-y0S7Z25NlrG_n@paquier.xyz
Backpatch-through: 18

diff --git a/src/bin/pg_dump/t/002_pg_dump.pl b/src/bin/pg_dump/t/002_pg_dump.pl
index dae5641f24e3ceaae7dc38f31b310011e6c6db52..99bdbcd086790e8b6618a4dfac6b866b48083bd5 100644 (file)
--- a/src/bin/pg_dump/t/002_pg_dump.pl
+++ b/src/bin/pg_dump/t/002_pg_dump.pl
@@ -985,8 +985,7 @@ my %full_runs = (
        no_table_access_method => 1,
        pg_dumpall_dbprivs => 1,
        pg_dumpall_exclude => 1,
-       schema_only => 1,
-       schema_only_with_statistics => 1,);
+       schema_only => 1,);
 
 # This is where the actual tests are defined.
 my %tests = (
@@ -1202,7 +1201,6 @@ my %tests = (
                        no_large_objects => 1,
                        no_owner => 1,
                        schema_only => 1,
-                       schema_only_with_statistics => 1,
                },
        },
 
@@ -1756,7 +1754,6 @@ my %tests = (
                },
                unlike => {
                        schema_only => 1,
-                       schema_only_with_statistics => 1,
                        no_large_objects => 1,
                },
        },
@@ -1781,7 +1778,6 @@ my %tests = (
                        binary_upgrade => 1,
                        no_large_objects => 1,
                        schema_only => 1,
-                       schema_only_with_statistics => 1,
                },
        },
 
@@ -1804,7 +1800,6 @@ my %tests = (
                        binary_upgrade => 1,
                        no_large_objects => 1,
                        schema_only => 1,
-                       schema_only_with_statistics => 1,
                },
        },
 
@@ -1971,7 +1966,6 @@ my %tests = (
                unlike => {
                        no_large_objects => 1,
                        schema_only => 1,
-                       schema_only_with_statistics => 1,
                },
        },
 
@@ -2154,7 +2148,6 @@ my %tests = (
                        exclude_test_table => 1,
                        exclude_test_table_data => 1,
                        schema_only => 1,
-                       schema_only_with_statistics => 1,
                        only_dump_measurement => 1,
                },
        },
@@ -2180,7 +2173,6 @@ my %tests = (
                        binary_upgrade => 1,
                        exclude_dump_test_schema => 1,
                        schema_only => 1,
-                       schema_only_with_statistics => 1,
                        only_dump_measurement => 1,
                },
        },
@@ -2221,7 +2213,6 @@ my %tests = (
                        binary_upgrade => 1,
                        exclude_dump_test_schema => 1,
                        schema_only => 1,
-                       schema_only_with_statistics => 1,
                        only_dump_measurement => 1,
                },
        },
@@ -2245,7 +2236,6 @@ my %tests = (
                        binary_upgrade => 1,
                        exclude_dump_test_schema => 1,
                        schema_only => 1,
-                       schema_only_with_statistics => 1,
                        only_dump_measurement => 1,
                },
        },
@@ -2270,7 +2260,6 @@ my %tests = (
                        binary_upgrade => 1,
                        exclude_dump_test_schema => 1,
                        schema_only => 1,
-                       schema_only_with_statistics => 1,
                        only_dump_measurement => 1,
                },
        },
@@ -2294,7 +2283,6 @@ my %tests = (
                        binary_upgrade => 1,
                        exclude_dump_test_schema => 1,
                        schema_only => 1,
-                       schema_only_with_statistics => 1,
                        only_dump_measurement => 1,
                },
        },
@@ -2318,7 +2306,6 @@ my %tests = (
                        binary_upgrade => 1,
                        exclude_dump_test_schema => 1,
                        schema_only => 1,
-                       schema_only_with_statistics => 1,
                        only_dump_measurement => 1,
                },
        },
@@ -3800,7 +3787,6 @@ my %tests = (
                        binary_upgrade => 1,
                        exclude_dump_test_schema => 1,
                        schema_only => 1,
-                       schema_only_with_statistics => 1,
                },
        },
 
@@ -3973,7 +3959,6 @@ my %tests = (
                unlike => {
                        binary_upgrade => 1,
                        schema_only => 1,
-                       schema_only_with_statistics => 1,
                        exclude_measurement => 1,
                        only_dump_test_schema => 1,
                        test_schema_plus_large_objects => 1,
@@ -4856,7 +4841,6 @@ my %tests = (
                        no_large_objects => 1,
                        no_privs => 1,
                        schema_only => 1,
-                       schema_only_with_statistics => 1,
                },
        },
 
@@ -4975,7 +4959,6 @@ my %tests = (
                        binary_upgrade => 1,
                        exclude_dump_test_schema => 1,
                        schema_only => 1,
-                       schema_only_with_statistics => 1,
                        only_dump_measurement => 1,
                },
        },
@@ -4992,7 +4975,6 @@ my %tests = (
                        binary_upgrade => 1,
                        exclude_dump_test_schema => 1,
                        schema_only => 1,
-                       schema_only_with_statistics => 1,
                        only_dump_measurement => 1,
                },
        },
@@ -5193,7 +5175,6 @@ my %tests = (
                        statistics_only => 1,
                        statistics_only_with_schema => 1,
                        statistics_only_with_index => 1,
-                       schema_only_with_statistics => 1,
                },
                unlike => {
                        exclude_dump_test_schema => 1,
@@ -5225,7 +5206,6 @@ my %tests = (
                        statistics_only_with_schema => 1,
                        statistics_only_with_index => 1,
                        statistics_only_with_table => 1,
-                       schema_only_with_statistics => 1,
                },
                unlike => {
                        no_statistics => 1,