serious bug in cpuworker. need to think about redesign or how to handle it.

svn:r448

diff --git a/src/or/cpuworker.c b/src/or/cpuworker.c
index 0b92733f2b2df1e7321256a56851d44cfe74fbeb..9d88afab6ee4afe9e2f9b71b4fffa33de6204743 100644 (file)
--- a/src/or/cpuworker.c
+++ b/src/or/cpuworker.c
@@ -55,6 +55,7 @@ int connection_cpu_process_inbuf(connection_t *conn) {
 
     connection_fetch_from_buf(buf,LEN_ONION_RESPONSE,conn);
 
+    /* XXX conn->circ might already have been closed. Serious bug. Suck. */
     if(*buf == 0 || conn->circ->p_conn == NULL ||
        onionskin_process(conn->circ, buf+1, buf+1+DH_KEY_LEN) < 0) {
       log_fn(LOG_DEBUG,"decoding onion, onionskin_process, or p_conn failed. Closing.");