]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
smbd: Fix CID 1455912 Logically dead code
authorVolker Lendecke <vl@samba.org>
Tue, 19 Nov 2019 13:23:52 +0000 (14:23 +0100)
committerAndreas Schneider <asn@cryptomilk.org>
Tue, 19 Nov 2019 16:13:36 +0000 (16:13 +0000)
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
source3/smbd/oplock.c

index ad993cc95b04205abbdaebcff348447220123362..6a3b1f77688dfebf4a17285146a8f5352ec50f04 100644 (file)
@@ -1032,7 +1032,7 @@ static void process_oplock_break_message(struct messaging_context *msg_ctx,
                return;
        }
 
-       if ((break_from == SMB2_LEASE_NONE) && !break_needed) {
+       if (break_from == SMB2_LEASE_NONE) {
                struct file_id_buf idbuf;
                DBG_NOTICE("Already downgraded oplock to none on %s: %s\n",
                           file_id_str_buf(fsp->file_id, &idbuf),
@@ -1043,7 +1043,7 @@ static void process_oplock_break_message(struct messaging_context *msg_ctx,
        DEBUG(10, ("break_from=%u, break_to=%u\n",
                   (unsigned)break_from, (unsigned)break_to));
 
-       if ((break_from == break_to) && !break_needed) {
+       if (break_from == break_to) {
                struct file_id_buf idbuf;
                DBG_NOTICE("Already downgraded oplock to %u on %s: %s\n",
                           (unsigned)break_to,