]> git.ipfire.org Git - thirdparty/openembedded/openembedded-core-contrib.git/commitdiff
recipetool: pypi: do not clobber SRC_URI checksums
authorTim Orling <ticotimo@gmail.com>
Sat, 9 Dec 2023 01:40:04 +0000 (17:40 -0800)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Sat, 9 Dec 2023 10:24:15 +0000 (10:24 +0000)
The pypi change:
"85a2a6f68af recipetool: create_buildsys_python: add pypi support"
deleted all the SRC_URI variables, including the SRC_URI checksums.
These are not generated by the pypi.bbclass (how could they be trusted?)

Without the checksum(s), we are vulnerable to a man-in-the-middle attack
and zero checks on the validity of the downloaded tarball from pypi.org.

Fix by only setting S and SRC_URI to None.

Signed-off-by: Tim Orling <tim.orling@konsulko.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
scripts/lib/recipetool/create_buildsys_python.py

index 5e07222ece1334d53103593afc29451c161746a3..a2af41fdda8a0fd6728eb2d74b0baa60b27bd5cc 100644 (file)
@@ -167,16 +167,11 @@ class PythonRecipeHandler(RecipeHandler):
                 if pypi_package_ext != "tar.gz":
                     extravalues["PYPI_PACKAGE_EXT"] = pypi_package_ext
 
-            # Pypi class will handle S and SRC_URIxxx variables, so remove them
+            # Pypi class will handle S and SRC_URI variables, so remove them
             # TODO: allow oe.recipeutils.patch_recipe_lines() to accept regexp so we can simplify the following to:
             # extravalues['SRC_URI(?:\[.*?\])?'] = None
             extravalues['S'] = None
             extravalues['SRC_URI'] = None
-            extravalues['SRC_URI[md5sum]'] = None
-            extravalues['SRC_URI[sha1sum]'] = None
-            extravalues['SRC_URI[sha256sum]'] = None
-            extravalues['SRC_URI[sha384sum]'] = None
-            extravalues['SRC_URI[sha512sum]'] = None
 
             classes.append('pypi')