]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
networkd: rename manager_connect_varlink() → manager_varlink_init()
authorLennart Poettering <lennart@poettering.net>
Mon, 13 Oct 2025 10:35:35 +0000 (12:35 +0200)
committerLennart Poettering <lennart@poettering.net>
Sat, 15 Nov 2025 06:52:42 +0000 (07:52 +0100)
This function doesn't "connect" to Varlink (i.e. it isn't a client) but
it binds a Varlink socket (i.e. it is server), hence let's remove the
verb "connect" from its name. let's copy how machined/resolved name the
counterpart for this function: manager_varlink_init()

src/network/networkd-manager-varlink.c
src/network/networkd-manager-varlink.h
src/network/networkd-manager.c

index cc46e60e4055374f6f44bc774851544c77aafdc6..a83665b982d672020053afc48bf01d443434dd94 100644 (file)
@@ -279,9 +279,9 @@ static int vl_method_set_persistent_storage(sd_varlink *vlink, sd_json_variant *
         return sd_varlink_reply(vlink, NULL);
 }
 
-int manager_connect_varlink(Manager *m, int fd) {
+int manager_varlink_init(Manager *m, int fd) {
         _cleanup_(sd_varlink_server_unrefp) sd_varlink_server *s = NULL;
-        _unused_ _cleanup_close_ int fd_close = fd;
+        _unused_ _cleanup_close_ int fd_close = fd; /* take possession */
         int r;
 
         assert(m);
index 0933c2a0566b9d58aa355f5a5d2893333a0c1ebd..edbc76859fc7f255099cb55f835a914171aafd89 100644 (file)
@@ -3,4 +3,4 @@
 
 #include "networkd-forward.h"
 
-int manager_connect_varlink(Manager *m, int fd);
+int manager_varlink_init(Manager *m, int fd);
index 762f1ca190182a4740fba74171157914c461e501..fc0a435554196c66e676e322ad1e1ea2470ef461 100644 (file)
@@ -595,7 +595,7 @@ int manager_setup(Manager *m) {
         if (m->test_mode)
                 return 0;
 
-        r = manager_connect_varlink(m, TAKE_FD(varlink_fd));
+        r = manager_varlink_init(m, TAKE_FD(varlink_fd));
         if (r < 0)
                 return r;