net: qrtr: ns: Limit the maximum number of lookups

Current code does no bound checking on the number of lookups a client can
perform. Though the code restricts the lookups to local clients, there is
still a possibility of a malicious local client sending a flood of
NEW_LOOKUP messages over the same socket.

Fix this issue by limiting the maximum number of lookups to 64 globally.
Since the nameserver allows only atmost one local observer, this global
lookup count will ensure that the lookups stay within the limit.

Note that, limit of 64 is chosen based on the current platform
requirements. If requirement changes in the future, this limit can be
increased.

Cc: stable@vger.kernel.org
Fixes: 0c2204a4ad71 ("net: qrtr: Migrate nameservice to kernel from userspace")
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
Link: https://patch.msgid.link/20260409-qrtr-fix-v3-2-00a8a5ff2b51@oss.qualcomm.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

diff --git a/net/qrtr/ns.c b/net/qrtr/ns.c
index 63cb5861d87a131620e9c064d79ab8449c15a377..5b08d4d4840a3c0f139b608d7a0b725b9eb2c9b8 100644 (file)
--- a/net/qrtr/ns.c
+++ b/net/qrtr/ns.c
@@ -22,6 +22,7 @@ static struct {
        struct socket *sock;
        struct sockaddr_qrtr bcast_sq;
        struct list_head lookups;
+       u32 lookup_count;
        struct workqueue_struct *workqueue;
        struct work_struct work;
        int local_node;
@@ -70,10 +71,11 @@ struct qrtr_node {
        u32 server_count;
 };
 
-/* Max server limit is chosen based on the current platform requirements. If the
- * requirement changes in the future, this value can be increased.
+/* Max server, lookup limits are chosen based on the current platform requirements.
+ * If the requirement changes in the future, these values can be increased.
  */
 #define QRTR_NS_MAX_SERVERS 256
+#define QRTR_NS_MAX_LOOKUPS 64
 
 static struct qrtr_node *node_get(unsigned int node_id)
 {
@@ -433,6 +435,7 @@ static int ctrl_cmd_del_client(struct sockaddr_qrtr *from,
 
                list_del(&lookup->li);
                kfree(lookup);
+               qrtr_ns.lookup_count--;
        }
 
        /* Remove the server belonging to this port but don't broadcast
@@ -550,6 +553,11 @@ static int ctrl_cmd_new_lookup(struct sockaddr_qrtr *from,
        if (from->sq_node != qrtr_ns.local_node)
                return -EINVAL;
 
+       if (qrtr_ns.lookup_count >= QRTR_NS_MAX_LOOKUPS) {
+               pr_err_ratelimited("QRTR client node exceeds max lookup limit!\n");
+               return -ENOSPC;
+       }
+
        lookup = kzalloc_obj(*lookup);
        if (!lookup)
                return -ENOMEM;
@@ -558,6 +566,7 @@ static int ctrl_cmd_new_lookup(struct sockaddr_qrtr *from,
        lookup->service = service;
        lookup->instance = instance;
        list_add_tail(&lookup->li, &qrtr_ns.lookups);
+       qrtr_ns.lookup_count++;
 
        memset(&filter, 0, sizeof(filter));
        filter.service = service;
@@ -598,6 +607,7 @@ static void ctrl_cmd_del_lookup(struct sockaddr_qrtr *from,
 
                list_del(&lookup->li);
                kfree(lookup);
+               qrtr_ns.lookup_count--;
        }
 }