Include HiddenServiceDir in some warning messages

diff --git a/changes/bug4426 b/changes/bug4426
new file mode 100644 (file)
index 0000000..1322243
--- /dev/null
+++ b/changes/bug4426
@@ -0,0 +1,8 @@
+  o Minor features:
+
+    - When Tor ignores a hidden service specified in its
+      configuration, include the hidden service's directory in the
+      warning message.  Previously, we would only tell the user that
+      some hidden service was ignored.  Bugfix on 0.0.6; fixes bug
+      4426.
+

diff --git a/src/or/rendservice.c b/src/or/rendservice.c
index 0f5731912d83d42ba2f76e987184faf05e8ac48d..25695c5e68cf6b5859874f75d64e94dc598b41c7 100644 (file)
--- a/src/or/rendservice.c
+++ b/src/or/rendservice.c
@@ -171,14 +171,17 @@ rend_add_service(rend_service_t *service)
 
   if (service->auth_type != REND_NO_AUTH &&
       smartlist_len(service->clients) == 0) {
-    log_warn(LD_CONFIG, "Hidden service with client authorization but no "
-                        "clients; ignoring.");
+    log_warn(LD_CONFIG, "Hidden service (%s) with client authorization but no "
+                        "clients; ignoring.",
+             esc_for_log(service->directory));
     rend_service_free(service);
     return;
   }
 
   if (!smartlist_len(service->ports)) {
-    log_warn(LD_CONFIG, "Hidden service with no ports configured; ignoring.");
+    log_warn(LD_CONFIG, "Hidden service (%s) with no ports configured; "
+             "ignoring.",
+             esc_for_log(service->directory));
     rend_service_free(service);
   } else {
     int dupe = 0;