]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ACPI: CPPC: Fix remaining for_each_possible_cpu() to use online CPUs
authorSean V Kelley <skelley@nvidia.com>
Wed, 11 Feb 2026 21:22:54 +0000 (21:22 +0000)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Thu, 12 Feb 2026 11:43:01 +0000 (12:43 +0100)
per_cpu(cpc_desc_ptr, cpu) object is initialized for only the online
CPUs via acpi_soft_cpu_online() --> __acpi_processor_start() -->
acpi_cppc_processor_probe().

However, send_pcc_cmd() and acpi_get_psd_map() still iterate over all
possible CPUs. In acpi_get_psd_map(), encountering an offline CPU
returns -EFAULT, causing cppc_cpufreq initialization to fail.

This breaks systems booted with "nosmt" or "nosmt=force".

Fix by using for_each_online_cpu() in both functions.

Fixes: 80b8286aeec0 ("ACPI / CPPC: support for batching CPPC requests")
Signed-off-by: Sean V Kelley <skelley@nvidia.com>
Link: https://patch.msgid.link/20260211212254.30190-1-skelley@nvidia.com
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/acpi/cppc_acpi.c

index c67494939f7bc503477ea0f75e06292eb0d7a4df..431297cad76d1e48ac8ccc35586aafa3788ec214 100644 (file)
@@ -362,7 +362,7 @@ static int send_pcc_cmd(int pcc_ss_id, u16 cmd)
 end:
        if (cmd == CMD_WRITE) {
                if (unlikely(ret)) {
-                       for_each_possible_cpu(i) {
+                       for_each_online_cpu(i) {
                                struct cpc_desc *desc = per_cpu(cpc_desc_ptr, i);
 
                                if (!desc)
@@ -524,7 +524,7 @@ int acpi_get_psd_map(unsigned int cpu, struct cppc_cpudata *cpu_data)
        else if (pdomain->coord_type == DOMAIN_COORD_TYPE_SW_ANY)
                cpu_data->shared_type = CPUFREQ_SHARED_TYPE_ANY;
 
-       for_each_possible_cpu(i) {
+       for_each_online_cpu(i) {
                if (i == cpu)
                        continue;