]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
selftests/bpf: fix return value comparison for tests in test_libbpf.sh
authorQuentin Monnet <quentin.monnet@netronome.com>
Sat, 20 Oct 2018 21:58:44 +0000 (22:58 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 1 Dec 2019 08:16:46 +0000 (09:16 +0100)
[ Upstream commit c5fa5d602221362f8341ecd9e32d83194abf5bd9 ]

The return value for each test in test_libbpf.sh is compared with

    if (( $? == 0 )) ; then ...

This works well with bash, but not with dash, that /bin/sh is aliased to
on some systems (such as Ubuntu).

Let's replace this comparison by something that works on both shells.

Signed-off-by: Quentin Monnet <quentin.monnet@netronome.com>
Reviewed-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
tools/testing/selftests/bpf/test_libbpf.sh

index 8b1bc96d8e0ccc9b1550cfa3aa91abbfeb2b7a03..2989b2e2d856d3f546338b70fe5ad2ad3952c416 100755 (executable)
@@ -6,7 +6,7 @@ export TESTNAME=test_libbpf
 # Determine selftest success via shell exit code
 exit_handler()
 {
-       if (( $? == 0 )); then
+       if [ $? -eq 0 ]; then
                echo "selftests: $TESTNAME [PASS]";
        else
                echo "$TESTNAME: failed at file $LAST_LOADED" 1>&2