]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
scsi: st: Fix array overflow in st_setup()
authorKai Mäkisara <Kai.Makisara@kolumbus.fi>
Tue, 11 Mar 2025 11:25:14 +0000 (13:25 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 2 May 2025 05:40:49 +0000 (07:40 +0200)
[ Upstream commit a018d1cf990d0c339fe0e29b762ea5dc10567d67 ]

Change the array size to follow parms size instead of a fixed value.

Reported-by: Chenyuan Yang <chenyuan0y@gmail.com>
Closes: https://lore.kernel.org/linux-scsi/CALGdzuoubbra4xKOJcsyThdk5Y1BrAmZs==wbqjbkAgmKS39Aw@mail.gmail.com/
Signed-off-by: Kai Mäkisara <Kai.Makisara@kolumbus.fi>
Link: https://lore.kernel.org/r/20250311112516.5548-2-Kai.Makisara@kolumbus.fi
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/scsi/st.c

index 3b819c6b15a569609cb7281652b0b8e3a65202b6..465fe83b49e98581e16af2ed7274ec6d997babdf 100644 (file)
@@ -4144,7 +4144,7 @@ static void validate_options(void)
  */
 static int __init st_setup(char *str)
 {
-       int i, len, ints[5];
+       int i, len, ints[ARRAY_SIZE(parms) + 1];
        char *stp;
 
        stp = get_options(str, ARRAY_SIZE(ints), ints);