samba-tool: allow testparm to dump global section only

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15070

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: David Mulder <dmulder@suse.com>

diff --git a/python/samba/netcmd/testparm.py b/python/samba/netcmd/testparm.py
index b44dea1f141c2addc0a36b51c61a9f0a612ad6ec..41dbb4bd62362dc93a9fc2220ecb5830ce6db157 100644 (file)
--- a/python/samba/netcmd/testparm.py
+++ b/python/samba/netcmd/testparm.py
@@ -106,7 +106,10 @@ class cmd_testparm(Command):
                     try:
                         section = lp[section_name]
                     except KeyError:
-                        raise CommandError("Unknown section %s" % section_name)
+                        if section_name in ['global', 'globals']:
+                            lp.dump_globals()
+                        else:
+                            raise CommandError(f"Unknown section {section_name}")
                     else:
                         section.dump(lp.default_service, verbose)
                 else:

diff --git a/selftest/knownfail.d/samba-tool-testparm b/selftest/knownfail.d/samba-tool-testparm
deleted file mode 100644 (file)
index e2252dd..0000000
--- a/selftest/knownfail.d/samba-tool-testparm
+++ /dev/null
@@ -1 +0,0 @@
-^samba.tests.netcmd.samba.tests.netcmd.TestParmTests.test_section_globals