]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
tcp: ipv4: initialize unicast_sock sk_pacing_rate
authorEric Dumazet <edumazet@google.com>
Wed, 28 Jan 2015 13:47:11 +0000 (05:47 -0800)
committerLuis Henriques <luis.henriques@canonical.com>
Tue, 10 Feb 2015 13:38:50 +0000 (13:38 +0000)
commit 811230cd853d62f09ed0addd0ce9a1b9b0e13fb5 upstream.

When I added sk_pacing_rate field, I forgot to initialize its value
in the per cpu unicast_sock used in ip_send_unicast_reply()

This means that for sch_fq users, RST packets, or ACK packets sent
on behalf of TIME_WAIT sockets might be sent to slowly or even dropped
once we reach the per flow limit.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Fixes: 95bd09eb2750 ("tcp: TSO packets automatic sizing")
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
net/ipv4/ip_output.c

index a0ded0ba16ae344bd1e00cd5c39e4c7f0ae3d9b3..34ee97c6aced0cb53abf74c0bc487d6da0a2c6c8 100644 (file)
@@ -1512,6 +1512,7 @@ static DEFINE_PER_CPU(struct inet_sock, unicast_sock) = {
                .sk_wmem_alloc  = ATOMIC_INIT(1),
                .sk_allocation  = GFP_ATOMIC,
                .sk_flags       = (1UL << SOCK_USE_WRITE_QUEUE),
+               .sk_pacing_rate = ~0U,
        },
        .pmtudisc       = IP_PMTUDISC_WANT,
        .uc_ttl         = -1,