]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s3:winbind: Improve logging in wb_query_user_list.c
authorPavel Filipenský <pfilipen@redhat.com>
Fri, 24 Jun 2022 13:31:03 +0000 (15:31 +0200)
committerAndreas Schneider <asn@cryptomilk.org>
Fri, 15 Jul 2022 14:25:38 +0000 (14:25 +0000)
Signed-off-by: Pavel Filipenský <pfilipen@redhat.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
source3/winbindd/wb_query_user_list.c

index 5e80aae8469a45c42a339dcfb61cd21913d3fbbf..772d795f1c3aed88c826c1962374b6dcfcec00b5 100644 (file)
@@ -46,6 +46,9 @@ struct tevent_req *wb_query_user_list_send(TALLOC_CTX *mem_ctx,
        if (req == NULL) {
                return NULL;
        }
+
+       D_INFO("WB command user_list start.\nQuery users in domain %s.\n",
+              domain->name);
        state->ev = ev;
        state->domain = domain;
 
@@ -73,8 +76,8 @@ static void wb_query_user_list_gotrids(struct tevent_req *subreq)
                return;
        }
 
-       DEBUG(10, ("dcerpc_wbint_QueryUserList returned %d users\n",
-                  state->rids.num_rids));
+       D_DEBUG("dcerpc_wbint_QueryUserList returned %u users\n",
+               state->rids.num_rids);
 
        subreq = dcerpc_wbint_LookupRids_send(
                state, state->ev, dom_child_handle(state->domain),
@@ -101,7 +104,7 @@ static void wb_query_user_list_done(struct tevent_req *subreq)
                tevent_req_nterror(req, status);
                return;
        }
-
+       D_DEBUG("Processing %u principal(s).\n", state->names.num_principals);
        for (i=0; i<state->names.num_principals; i++) {
                struct wbint_Principal *p = &state->names.principals[i];
                const char *name;
@@ -117,6 +120,7 @@ static void wb_query_user_list_done(struct tevent_req *subreq)
                        tevent_req_nterror(req, map_nt_error_from_unix(ret));
                        return;
                }
+               D_DEBUG("%u: Adding user %s\n", i, name);
        }
 
        tevent_req_done(req);
@@ -129,7 +133,9 @@ NTSTATUS wb_query_user_list_recv(struct tevent_req *req, TALLOC_CTX *mem_ctx,
                req, struct wb_query_user_list_state);
        NTSTATUS status;
 
+       D_INFO("WB command user_list end.\n");
        if (tevent_req_is_nterror(req, &status)) {
+               D_WARNING("Failed with: %s\n", nt_errstr(status));
                return status;
        }