]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
drm/xe: Check pat.ops before dumping PAT settings
authorMichal Wajdeczko <michal.wajdeczko@intel.com>
Tue, 9 Apr 2024 10:51:06 +0000 (12:51 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 5 Jul 2024 07:38:01 +0000 (09:38 +0200)
[ Upstream commit a918e771e6fbe1fa68932af5b0cdf473e23090cc ]

We may leave pat.ops unset when running on brand new platform or
when running as a VF.  While the former is unlikely, the latter
is valid (future) use case and will cause NPD when someone will
try to dump PAT settings by debugfs.

It's better to check pointer to pat.ops instead of specific .dump
hook, as we have this hook always defined for every .ops variant.

Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Reviewed-by: Piotr Piórkowski <piotr.piorkowski@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240409105106.1067-2-michal.wajdeczko@intel.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/xe/xe_pat.c

index e148934d554b0d08beb23b9b08f534b7bff582e7..351ab902eb600f3826dca31f5e4577f470fcd60b 100644 (file)
@@ -457,7 +457,7 @@ void xe_pat_dump(struct xe_gt *gt, struct drm_printer *p)
 {
        struct xe_device *xe = gt_to_xe(gt);
 
-       if (!xe->pat.ops->dump)
+       if (!xe->pat.ops)
                return;
 
        xe->pat.ops->dump(gt, p);