]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
drm/msm/dpu: Don't use %pK through printk (again)
authorThomas Weißschuh <thomas.weissschuh@linutronix.de>
Mon, 23 Feb 2026 07:16:55 +0000 (08:16 +0100)
committerDmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Mon, 23 Feb 2026 23:32:20 +0000 (01:32 +0200)
In the past %pK was preferable to %p as it would not leak raw pointer
values into the kernel log.
Since commit ad67b74d2469 ("printk: hash addresses printed with %p")
the regular %p has been improved to avoid this issue.
Furthermore, restricted pointers ("%pK") were never meant to be used
through printk(). They can still unintentionally leak raw pointers or
acquire sleeping locks in atomic contexts.

Switch to the regular pointer formatting which is safer and
easier to reason about.

This was previously fixed in this driver in commit 1ba9fbe40337
("drm/msm: Don't use %pK through printk") but an additional usage
was reintroduced in commit 39a750ff5fc9 ("drm/msm/dpu: Add DSPP GC
driver to provide GAMMA_LUT DRM property")

Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
Fixes: 39a750ff5fc9 ("drm/msm/dpu: Add DSPP GC driver to provide GAMMA_LUT DRM property")
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Patchwork: https://patchwork.freedesktop.org/patch/706229/
Link: https://lore.kernel.org/r/20260223-restricted-pointers-msm-v1-1-14c0b451e372@linutronix.de
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dspp.c

index 188ee0af2c90fbad40db695a08bd6fa1531ea1f0..23dcbe1ce1b831b1af4e28455095e12d94b73695 100644 (file)
@@ -89,7 +89,7 @@ static void dpu_setup_dspp_gc(struct dpu_hw_dspp *ctx,
        base = ctx->cap->sblk->gc.base;
 
        if (!base) {
-               DRM_ERROR("invalid ctx %pK gc base\n", ctx);
+               DRM_ERROR("invalid ctx %p gc base\n", ctx);
                return;
        }