ctdb-tests: Avoid ShellCheck warnings SC2046, SC2005

In ./tests/UNIT/eventscripts/scripts/local.sh line 328:
	echo $(ctdb ifaces -X | awk -F'|' 'FNR > 1 {print $2}')
             ^-- SC2046 (warning): Quote this to prevent word splitting.
             ^-- SC2005 (style): Useless echo? Instead of 'echo $(cmd)', just use 'cmd'.

Use xargs to get output on 1 line.

Signed-off-by: Martin Schwenke <mschwenke@ddn.com>
Reviewed-by: Andreas Schneider <asn@samba.org>

diff --git a/ctdb/tests/UNIT/eventscripts/scripts/local.sh b/ctdb/tests/UNIT/eventscripts/scripts/local.sh
index e5d6ee502829cb6aec6983ad6d94fbb2c7772bb7..72c43bd7ee76e1fe2e67bc9c6553078a6a6fa538 100644 (file)
--- a/ctdb/tests/UNIT/eventscripts/scripts/local.sh
+++ b/ctdb/tests/UNIT/eventscripts/scripts/local.sh
@@ -319,8 +319,7 @@ ctdb_set_pnn()
 
 ctdb_get_interfaces()
 {
-       # The echo/subshell forces all the output onto 1 line.
-       echo $(ctdb ifaces -X | awk -F'|' 'FNR > 1 {print $2}')
+       ctdb ifaces -X | awk -F'|' 'FNR > 1 {print $2}' | xargs
 }
 
 ctdb_get_1_interface()