Fix a double-free in failing case of handle_control_authenticate.

Bugfix on ed8f020e205267e6270494634346ab68d830e1d8; bug not in any
released version of Tor.  Found by Coverity; this is CID 1239290.

diff --git a/src/or/control.c b/src/or/control.c
index 60aa869439eaed85b9df6d5d4422b332e1ea0104..7038b2cfd594b2bdc8b2e46f33db160080e49ece 100644 (file)
--- a/src/or/control.c
+++ b/src/or/control.c
@@ -1177,6 +1177,7 @@ handle_control_authenticate(control_connection_t *conn, uint32_t len,
       });
       SMARTLIST_FOREACH(sl, char *, cp, tor_free(cp));
       smartlist_free(sl);
+      sl = NULL;
 
       if (used_quoted_string)
         errstr = "Password did not match HashedControlPassword value from "