]> git.ipfire.org Git - thirdparty/kea.git/commitdiff
[2676] (minor) Explain a FIXME comment
authorMichal 'vorner' Vaner <michal.vaner@nic.cz>
Tue, 19 Feb 2013 10:04:07 +0000 (11:04 +0100)
committerMichal 'vorner' Vaner <michal.vaner@nic.cz>
Tue, 19 Feb 2013 10:04:07 +0000 (11:04 +0100)
src/bin/zonemgr/zonemgr.py.in

index 94e93f86cfc4dfe14b9859205e15a78fc382f60a..59900c4655a8a57ecaf86995d5beae7c29f4d635 100755 (executable)
@@ -279,7 +279,10 @@ class ZonemgrRefresh:
         """Send command between modules."""
         try:
             self._mccs.rpc_call(command_name, module_name, params=params)
-        except socket.error: # FIXME: WTF?
+        except socket.error:
+            # FIXME: WTF? Where does socket.error come from? And how do we ever
+            # dare ignore such serious error? It can only be broken link to
+            # msgq, we need to terminate then.
             logger.error(ZONEMGR_SEND_FAIL, module_name)
         except (isc.cc.session.SessionTimeout, isc.config.RPCError):
             pass        # for now we just ignore the failure