]> git.ipfire.org Git - thirdparty/asterisk.git/commitdiff
(closes issue #13871)
authorSteve Murphy <murf@digium.com>
Fri, 21 Nov 2008 21:19:47 +0000 (21:19 +0000)
committerSteve Murphy <murf@digium.com>
Fri, 21 Nov 2008 21:19:47 +0000 (21:19 +0000)
Reported by: mdu113

This one is totally my fault. The code doesn't even
create a bridge if the channel CDR has POST_DISABLED.
I didn't check for that at the end of the bridge.
Fixed with a few small insertions. Tested. Looks
good. No cdr generated, no crash, no unnecc. data
objects created either.

git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@158483 65c4cc65-6c06-0410-ace0-fbb531ad65f3

res/res_features.c

index a5c3dc9b5284d674c6ae69ae38f281b021139458..31f3aa9359a0cf75f90c326779ea1d03c1347ce2 100644 (file)
@@ -1772,13 +1772,15 @@ int ast_bridge_call(struct ast_channel *chan,struct ast_channel *peer,struct ast
        /* obey the NoCDR() wishes. -- move the DISABLED flag to the bridge CDR if it was set on the channel during the bridge... */
        if (res != AST_PBX_KEEPALIVE) {
                new_chan_cdr = pick_unlocked_cdr(chan->cdr); /* the proper chan cdr, if there are forked cdrs */
-               if (new_chan_cdr && ast_test_flag(new_chan_cdr, AST_CDR_FLAG_POST_DISABLED))
+               if (bridge_cdr && new_chan_cdr && ast_test_flag(new_chan_cdr, AST_CDR_FLAG_POST_DISABLED))
                        ast_set_flag(bridge_cdr, AST_CDR_FLAG_POST_DISABLED);
        }
 
        /* we can post the bridge CDR at this point */
-       ast_cdr_end(bridge_cdr);
-       ast_cdr_detach(bridge_cdr);
+       if (bridge_cdr) {
+               ast_cdr_end(bridge_cdr);
+               ast_cdr_detach(bridge_cdr);
+       }
        
        /* do a specialized reset on the beginning channel
           CDR's, if they still exist, so as not to mess up