]> git.ipfire.org Git - thirdparty/tor.git/commitdiff
Remove comment complaining that we try to attach all streams to circs
authorRobert Ransom <rransom.8774@gmail.com>
Wed, 7 Dec 2011 03:24:55 +0000 (19:24 -0800)
committerNick Mathewson <nickm@torproject.org>
Fri, 9 Dec 2011 16:28:42 +0000 (11:28 -0500)
It's inefficient, but the more efficient solution (only try to attach
streams aiming for this HS) would require far more complexity for a gain
that should be tiny.

src/or/rendclient.c

index c4744731dfbe3c62f892d6ef033cc196c69a8aca..8aae8c5cb5bf554fbd18db6418f2b33886216b23 100644 (file)
@@ -893,9 +893,6 @@ rend_client_receive_rendezvous(origin_circuit_t *circ, const uint8_t *request,
   onion_append_to_cpath(&circ->cpath, hop);
   circ->build_state->pending_final_cpath = NULL; /* prevent double-free */
 
-  /* XXXX023 This is a pretty brute-force approach. It'd be better to
-   * attach only the connections that are waiting on this circuit, rather
-   * than trying to attach them all. See comments bug 743. */
   circuit_try_attaching_streams(circ);
 
   memset(keys, 0, sizeof(keys));