]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
NTB: Fix an error code in ntb_msit_probe()
authorYang Li <yang.lee@linux.alibaba.com>
Mon, 7 Jun 2021 05:56:20 +0000 (13:56 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 22 Sep 2021 10:26:44 +0000 (12:26 +0200)
[ Upstream commit 319f83ac98d7afaabab84ce5281a819a358b9895 ]

When the value of nm->isr_ctx is false, the value of ret is 0.
So, we set ret to -ENOMEM to indicate this error.

Clean up smatch warning:
drivers/ntb/test/ntb_msi_test.c:373 ntb_msit_probe() warn: missing
error code 'ret'.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
Signed-off-by: Jon Mason <jdmason@kudzu.us>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/ntb/test/ntb_msi_test.c

index 99d826ed9c341e57281df42e72ff6ae2d84768d6..662067dc9ce2c36f999cb61c4fc60eaf4e7060b3 100644 (file)
@@ -372,8 +372,10 @@ static int ntb_msit_probe(struct ntb_client *client, struct ntb_dev *ntb)
        if (ret)
                goto remove_dbgfs;
 
-       if (!nm->isr_ctx)
+       if (!nm->isr_ctx) {
+               ret = -ENOMEM;
                goto remove_dbgfs;
+       }
 
        ntb_link_enable(ntb, NTB_SPEED_AUTO, NTB_WIDTH_AUTO);