typing.py: Consider ellipsis in TupleMeta.__eq__. By Kalle Tuure. github.com/python...

diff --git a/Lib/test/test_typing.py b/Lib/test/test_typing.py
index b39efcf01913d81ef3c41b3b2eabd1ed8bd646f4..47118edc691984c28c2d7926405e46b0978dcba5 100644 (file)
--- a/Lib/test/test_typing.py
+++ b/Lib/test/test_typing.py
@@ -359,6 +359,12 @@ class TupleTests(TestCase):
         self.assertTrue(issubclass(tuple, Tuple))
         self.assertFalse(issubclass(Tuple, tuple))  # Can't have it both ways.
 
+    def test_equality(self):
+        assert Tuple[int] == Tuple[int]
+        assert Tuple[int, ...] == Tuple[int, ...]
+        assert Tuple[int] != Tuple[int, int]
+        assert Tuple[int] != Tuple[int, ...]
+
     def test_tuple_subclass(self):
         class MyTuple(tuple):
             pass

diff --git a/Lib/typing.py b/Lib/typing.py
index 42a9ea3d660c82bc7a4e338b2cf9bb3234fd3572..d2750111d4502e159108767206e1796675033392 100644 (file)
--- a/Lib/typing.py
+++ b/Lib/typing.py
@@ -705,7 +705,8 @@ class TupleMeta(TypingMeta):
     def __eq__(self, other):
         if not isinstance(other, TupleMeta):
             return NotImplemented
-        return self.__tuple_params__ == other.__tuple_params__
+        return (self.__tuple_params__ == other.__tuple_params__ and
+                self.__tuple_use_ellipsis__ == other.__tuple_use_ellipsis__)
 
     def __hash__(self):
         return hash(self.__tuple_params__)