VMCIDoorbell_Destroy: Assert when destroying non existent handle.

The VMCINotificationUnregister function in the vmci guest driver
was asserting FALSE when destroying a doorbell handle that does not
exist in the internal hash. This was causing the guest kernel to panic
when trying to destroy a handle that was already destroyed.

We should probably just return VMCI_ERROR_NOT_FOUND here instead of
asserting.

Signed-off-by: Marcelo Vanzin <mvanzin@vmware.com>

diff --git a/open-vm-tools/modules/linux/vmci/vmciNotifications.c b/open-vm-tools/modules/linux/vmci/vmciNotifications.c
index 740fcda224c9b8804a86147d9be38f697e832e22..90f9b7990b18fbd62a52befa45167372f942229a 100644 (file)
--- a/open-vm-tools/modules/linux/vmci/vmciNotifications.c
+++ b/open-vm-tools/modules/linux/vmci/vmciNotifications.c
@@ -831,7 +831,6 @@ VMCINotificationUnregister(VMCIHandle handle, // IN
 
    entry = VMCINotifyHashRemoveEntry(handle, doorbell);
    if (!entry) {
-      ASSERT(FALSE);
       return VMCI_ERROR_NOT_FOUND;
    }