]> git.ipfire.org Git - thirdparty/squid.git/commitdiff
Bug 2588: coredump in rDNS lookup
authorAmos Jeffries <squid3@treenet.co.nz>
Thu, 5 Feb 2009 07:50:56 +0000 (20:50 +1300)
committerAmos Jeffries <squid3@treenet.co.nz>
Thu, 5 Feb 2009 07:50:56 +0000 (20:50 +1300)
Handle rDNS of invalid IP gracefully.

src/fqdncache.cc

index 371274e177249ec10c7dcf99d78d09cf0611faa6..1e55d4fb52d573b74751b838e8177a9f32c7271b 100644 (file)
@@ -639,7 +639,10 @@ fqdncache_gethostbyaddr(IpAddress &addr, int flags)
     char name[MAX_IPSTRLEN];
     fqdncache_entry *f = NULL;
 
-    assert(!addr.IsAnyAddr() && !addr.IsNoAddr());
+    if (addr.IsAnyAddr() || addr.IsNoAddr()) {
+        return NULL;
+    }
+
     addr.NtoA(name,MAX_IPSTRLEN);
     FqdncacheStats.requests++;
     f = fqdncache_get(name);