]> git.ipfire.org Git - thirdparty/openwrt.git/commitdiff
hostapd: fix type mismatch in BSS transition responses
authorFelix Fietkau <nbd@nbd.name>
Wed, 18 Mar 2026 18:42:06 +0000 (18:42 +0000)
committerFelix Fietkau <nbd@nbd.name>
Thu, 19 Mar 2026 09:57:26 +0000 (10:57 +0100)
Use blobmsg_add_u32 for non-bool fields in order to avoid wrong
interpretations of the data on JSON/ucode conversion.

Signed-off-by: Felix Fietkau <nbd@nbd.name>
package/network/services/hostapd/src/src/ap/ubus.c

index 8e27606816ffe650be1e1d1b567e5a910f223038..748690c5c3e282f179a0d1be0fe1b731f7c0e6ca 100644 (file)
@@ -2093,9 +2093,9 @@ void hostapd_ubus_notify_bss_transition_response(
 
        blob_buf_init(&b, 0);
        blobmsg_add_macaddr(&b, "address", addr);
-       blobmsg_add_u8(&b, "dialog-token", dialog_token);
-       blobmsg_add_u8(&b, "status-code", status_code);
-       blobmsg_add_u8(&b, "bss-termination-delay", bss_termination_delay);
+       blobmsg_add_u32(&b, "dialog-token", dialog_token);
+       blobmsg_add_u32(&b, "status-code", status_code);
+       blobmsg_add_u32(&b, "bss-termination-delay", bss_termination_delay);
        if (target_bssid)
                blobmsg_add_macaddr(&b, "target-bssid", target_bssid);
 
@@ -2122,8 +2122,8 @@ int hostapd_ubus_notify_bss_transition_query(
 
        blob_buf_init(&b, 0);
        blobmsg_add_macaddr(&b, "address", addr);
-       blobmsg_add_u8(&b, "dialog-token", dialog_token);
-       blobmsg_add_u8(&b, "reason", reason);
+       blobmsg_add_u32(&b, "dialog-token", dialog_token);
+       blobmsg_add_u32(&b, "reason", reason);
        hostapd_ubus_notify_bss_transition_add_candidate_list(candidate_list, candidate_list_len);
 
        if (!hapd->ubus.notify_response) {