]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
unit-name: use TAKE_PTR() where appropriate
authorLennart Poettering <lennart@poettering.net>
Sun, 24 May 2020 22:37:15 +0000 (00:37 +0200)
committerLennart Poettering <lennart@poettering.net>
Tue, 26 May 2020 07:17:48 +0000 (09:17 +0200)
src/basic/unit-name.c

index 312168054a7b802bfc5d84420d8a0b2d0d880925..10405b711f671bbfdd50575523e34731ec13288a 100644 (file)
@@ -695,7 +695,8 @@ good:
 }
 
 int slice_build_parent_slice(const char *slice, char **ret) {
-        char *s, *dash;
+        _cleanup_free_ char *s = NULL;
+        char *dash;
         int r;
 
         assert(slice);
@@ -718,13 +719,11 @@ int slice_build_parent_slice(const char *slice, char **ret) {
                 strcpy(dash, ".slice");
         else {
                 r = free_and_strdup(&s, SPECIAL_ROOT_SLICE);
-                if (r < 0) {
-                        free(s);
+                if (r < 0)
                         return r;
-                }
         }
 
-        *ret = s;
+        *ret = TAKE_PTR(s);
         return 1;
 }