]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
selftests/bpf: Close obj in error path in xdp_adjust_tail
authorGeliang Tang <tanggeliang@kylinos.cn>
Wed, 10 Jul 2024 13:10:17 +0000 (21:10 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 3 Aug 2024 06:59:45 +0000 (08:59 +0200)
[ Upstream commit 52b49ec1b2c78deb258596c3b231201445ef5380 ]

If bpf_object__load() fails in test_xdp_adjust_frags_tail_grow(), "obj"
opened before this should be closed. So use "goto out" to close it instead
of using "return" here.

Fixes: 110221081aac ("bpf: selftests: update xdp_adjust_tail selftest to include xdp frags")
Signed-off-by: Geliang Tang <tanggeliang@kylinos.cn>
Link: https://lore.kernel.org/r/f282a1ed2d0e3fb38cceefec8e81cabb69cab260.1720615848.git.tanggeliang@kylinos.cn
Signed-off-by: Martin KaFai Lau <martin.lau@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
tools/testing/selftests/bpf/prog_tests/xdp_adjust_tail.c

index f09505f8b0386c7b837d8768aa2b8407b5f8f54b..53d6ad8c2257eb6870c807950ca3709a6d4ddfa5 100644 (file)
@@ -222,7 +222,7 @@ static void test_xdp_adjust_frags_tail_grow(void)
 
        prog = bpf_object__next_program(obj, NULL);
        if (bpf_object__load(obj))
-               return;
+               goto out;
 
        prog_fd = bpf_program__fd(prog);