free buffer on all error paths

diff --git a/src/protocols/dhcpv4/udp.c b/src/protocols/dhcpv4/udp.c
index be1ab6bf1fcc3407f7d283bfbbd7bdd1ae80df48..284c5bfd225a9f2e9f2d6f98902115664a92f870 100644 (file)
--- a/src/protocols/dhcpv4/udp.c
+++ b/src/protocols/dhcpv4/udp.c
@@ -122,7 +122,7 @@ fr_packet_t *fr_dhcpv4_udp_packet_recv(int sockfd)
        fr_ipaddr_from_sockaddr(&dst_ipaddr, &dst_port, &dst, sizeof_dst);
        fr_ipaddr_from_sockaddr(&src_ipaddr, &src_port, &src, sizeof_src);
 
-       if (!fr_dhcpv4_ok(data, data_len, NULL, NULL)) return NULL;
+       if (!fr_dhcpv4_ok(data, data_len, NULL, NULL)) goto error;
 
        packet = fr_dhcpv4_packet_alloc(data, data_len);
        if (!packet) goto error;