]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
wifi: ath10k: remove gpio number assignment
authorArnd Bergmann <arnd@arndb.de>
Fri, 8 Aug 2025 15:18:00 +0000 (17:18 +0200)
committerJeff Johnson <jeff.johnson@oss.qualcomm.com>
Thu, 18 Sep 2025 23:43:48 +0000 (16:43 -0700)
The leds-gpio traditionally takes a global gpio number in its platform
data, but the number assigned here is not actually such a number but
only meant to be used internally to this driver.

As part of the kernel-wide cleanup of the old gpiolib interfaces, the
'gpio' number field is going away, so to keep ath10k building, move
the assignment into a private structure instead.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Baochen Qiang <baochen.qiang@oss.qualcomm.com>
Link: https://patch.msgid.link/20250808151822.536879-17-arnd@kernel.org
Signed-off-by: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
drivers/net/wireless/ath/ath10k/leds.c

index 9b1d04eb4265bd3dd0bc73df2eed57ffbeaeef3c..3a6c8111e7c6388641404ed50534422a2be33ed3 100644 (file)
@@ -27,7 +27,7 @@ static int ath10k_leds_set_brightness_blocking(struct led_classdev *led_cdev,
                goto out;
 
        ar->leds.gpio_state_pin = (brightness != LED_OFF) ^ led->active_low;
-       ath10k_wmi_gpio_output(ar, led->gpio, ar->leds.gpio_state_pin);
+       ath10k_wmi_gpio_output(ar, ar->hw_params.led_pin, ar->leds.gpio_state_pin);
 
 out:
        mutex_unlock(&ar->conf_mutex);
@@ -64,7 +64,6 @@ int ath10k_leds_register(struct ath10k *ar)
        snprintf(ar->leds.label, sizeof(ar->leds.label), "ath10k-%s",
                 wiphy_name(ar->hw->wiphy));
        ar->leds.wifi_led.active_low = 1;
-       ar->leds.wifi_led.gpio = ar->hw_params.led_pin;
        ar->leds.wifi_led.name = ar->leds.label;
        ar->leds.wifi_led.default_state = LEDS_GPIO_DEFSTATE_KEEP;