]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
net/mlx5e: Correct the calculation of max channels for rep
authorMoshe Tal <moshet@nvidia.com>
Wed, 27 Apr 2022 15:26:52 +0000 (18:26 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 9 Jun 2022 08:30:16 +0000 (10:30 +0200)
[ Upstream commit 6d0ba49321a40a8dada22c223bbe91c063b08db4 ]

Correct the calculation of maximum channels of rep to better utilize
the hardware resources and allow a larger scale of reps.

This will allow creation of all virtual ports configured.

Fixes: 473baf2e9e8c ("net/mlx5e: Allow profile-specific limitation on max num of channels")
Signed-off-by: Moshe Tal <moshet@nvidia.com>
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/mellanox/mlx5/core/en.h
drivers/net/ethernet/mellanox/mlx5/core/en_main.c
drivers/net/ethernet/mellanox/mlx5/core/en_rep.c

index 8653ac0fd865cc35b957a14c06c02a1d43d1b71a..ee34e861d3af63aa7ff4e7ea366f06c7970c63c2 100644 (file)
@@ -1221,6 +1221,7 @@ mlx5e_tx_mpwqe_supported(struct mlx5_core_dev *mdev)
                MLX5_CAP_ETH(mdev, enhanced_multi_pkt_send_wqe);
 }
 
+int mlx5e_get_pf_num_tirs(struct mlx5_core_dev *mdev);
 int mlx5e_priv_init(struct mlx5e_priv *priv,
                    const struct mlx5e_profile *profile,
                    struct net_device *netdev,
index fa229998606c2ac49111257922fffea11191c250..72867a8ff48b6094d84f792163fcdb6f3b0a013f 100644 (file)
@@ -5251,6 +5251,15 @@ mlx5e_calc_max_nch(struct mlx5_core_dev *mdev, struct net_device *netdev,
        return max_nch;
 }
 
+int mlx5e_get_pf_num_tirs(struct mlx5_core_dev *mdev)
+{
+       /* Indirect TIRS: 2 sets of TTCs (inner + outer steering)
+        * and 1 set of direct TIRS
+        */
+       return 2 * MLX5E_NUM_INDIR_TIRS
+               + mlx5e_profile_max_num_channels(mdev, &mlx5e_nic_profile);
+}
+
 /* mlx5e generic netdev management API (move to en_common.c) */
 int mlx5e_priv_init(struct mlx5e_priv *priv,
                    const struct mlx5e_profile *profile,
index 6b7e7ea6ded2327be94d48dfe1b1ef249185ff68..a464461f1418938abed6502b80c84094be28bed0 100644 (file)
@@ -604,10 +604,16 @@ bool mlx5e_eswitch_vf_rep(const struct net_device *netdev)
        return netdev->netdev_ops == &mlx5e_netdev_ops_rep;
 }
 
+/* One indirect TIR set for outer. Inner not supported in reps. */
+#define REP_NUM_INDIR_TIRS MLX5E_NUM_INDIR_TIRS
+
 static int mlx5e_rep_max_nch_limit(struct mlx5_core_dev *mdev)
 {
-       return (1 << MLX5_CAP_GEN(mdev, log_max_tir)) /
-               mlx5_eswitch_get_total_vports(mdev);
+       int max_tir_num = 1 << MLX5_CAP_GEN(mdev, log_max_tir);
+       int num_vports = mlx5_eswitch_get_total_vports(mdev);
+
+       return (max_tir_num - mlx5e_get_pf_num_tirs(mdev)
+               - (num_vports * REP_NUM_INDIR_TIRS)) / num_vports;
 }
 
 static void mlx5e_build_rep_params(struct net_device *netdev)