]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
gpio: ljca: Fix duplicated IRQ mapping
authorHaotian Zhang <vulab@iscas.ac.cn>
Thu, 23 Oct 2025 07:02:30 +0000 (15:02 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 29 Oct 2025 13:07:04 +0000 (14:07 +0100)
[ Upstream commit 4c4e6ea4a120cc5ab58e437c6ba123cbfc357d45 ]

The generic_handle_domain_irq() function resolves the hardware IRQ
internally. The driver performed a duplicative mapping by calling
irq_find_mapping() first, which could lead to an RCU stall.

Delete the redundant irq_find_mapping() call and pass the hardware IRQ
directly to generic_handle_domain_irq().

Fixes: c5a4b6fd31e8 ("gpio: Add support for Intel LJCA USB GPIO driver")
Signed-off-by: Haotian Zhang <vulab@iscas.ac.cn>
Link: https://lore.kernel.org/r/20251023070231.1305-1-vulab@iscas.ac.cn
[Bartosz: remove unused variable]
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpio/gpio-ljca.c

index dfec9fbfc7a9bd8a98916a5ad2676aa380470852..ddd73b8b790e73a98c510a540de7bba5b591ea17 100644 (file)
@@ -281,22 +281,14 @@ static void ljca_gpio_event_cb(void *context, u8 cmd, const void *evt_data,
 {
        const struct ljca_gpio_packet *packet = evt_data;
        struct ljca_gpio_dev *ljca_gpio = context;
-       int i, irq;
+       int i;
 
        if (cmd != LJCA_GPIO_INT_EVENT)
                return;
 
        for (i = 0; i < packet->num; i++) {
-               irq = irq_find_mapping(ljca_gpio->gc.irq.domain,
-                                      packet->item[i].index);
-               if (!irq) {
-                       dev_err(ljca_gpio->gc.parent,
-                               "gpio_id %u does not mapped to IRQ yet\n",
-                               packet->item[i].index);
-                       return;
-               }
-
-               generic_handle_domain_irq(ljca_gpio->gc.irq.domain, irq);
+               generic_handle_domain_irq(ljca_gpio->gc.irq.domain,
+                                       packet->item[i].index);
                set_bit(packet->item[i].index, ljca_gpio->reenable_irqs);
        }