]> git.ipfire.org Git - thirdparty/vala.git/commitdiff
codegen: Drop unnecessary comma expression in postfix expressions
authorJürg Billeter <j@bitron.ch>
Sun, 10 Oct 2010 07:12:25 +0000 (09:12 +0200)
committerJürg Billeter <j@bitron.ch>
Sun, 10 Oct 2010 08:45:24 +0000 (10:45 +0200)
codegen/valaccodebasemodule.vala
codegen/valadovabasemodule.vala

index 3514b7d1e59736548f91dca549451d00c19aa74d..ddcdd79ccdc07960918aebea78a1a78ad0a1ae56 100644 (file)
@@ -3590,23 +3590,19 @@ public class Vala.CCodeBaseModule : CodeGenerator {
                        // property postfix expression
                        var prop = (Property) ma.symbol_reference;
                        
-                       var ccomma = new CCodeCommaExpression ();
-                       
                        // assign current value to temp variable
                        var temp_decl = get_temp_variable (prop.property_type, true, expr, false);
                        emit_temp_var (temp_decl);
-                       ccomma.append_expression (new CCodeAssignment (get_variable_cexpression (temp_decl.name), get_cvalue (expr.inner)));
+                       ccode.add_expression (new CCodeAssignment (get_variable_cexpression (temp_decl.name), get_cvalue (expr.inner)));
                        
                        // increment/decrement property
                        var op = expr.increment ? CCodeBinaryOperator.PLUS : CCodeBinaryOperator.MINUS;
                        var cexpr = new CCodeBinaryExpression (op, get_variable_cexpression (temp_decl.name), new CCodeConstant ("1"));
                        var ccall = get_property_set_call (prop, ma, cexpr);
-                       ccomma.append_expression (ccall);
+                       ccode.add_expression (ccall);
                        
                        // return previous value
-                       ccomma.append_expression (get_variable_cexpression (temp_decl.name));
-                       
-                       set_cvalue (expr, ccomma);
+                       set_cvalue (expr, get_variable_cexpression (temp_decl.name));
                        return;
                }
        
index 72e147fc893da8ca0f3a535439194d11ef64179a..7eb81b68a69e0c772306dfc615bdf7572b0e031b 100644 (file)
@@ -1369,23 +1369,19 @@ public class Vala.DovaBaseModule : CodeGenerator {
                        // property postfix expression
                        var prop = (Property) ma.symbol_reference;
 
-                       var ccomma = new CCodeCommaExpression ();
-
                        // assign current value to temp variable
                        var temp_decl = get_temp_variable (prop.property_type, true, expr);
                        emit_temp_var (temp_decl);
-                       ccomma.append_expression (new CCodeAssignment (get_variable_cexpression (temp_decl.name), get_cvalue (expr.inner)));
+                       ccode.add_expression (new CCodeAssignment (get_variable_cexpression (temp_decl.name), get_cvalue (expr.inner)));
 
                        // increment/decrement property
                        var op = expr.increment ? CCodeBinaryOperator.PLUS : CCodeBinaryOperator.MINUS;
                        var cexpr = new CCodeBinaryExpression (op, get_variable_cexpression (temp_decl.name), new CCodeConstant ("1"));
                        var ccall = get_property_set_call (prop, ma, cexpr);
-                       ccomma.append_expression (ccall);
+                       ccode.add_expression (ccall);
 
                        // return previous value
-                       ccomma.append_expression (new CCodeIdentifier (temp_decl.name));
-
-                       set_cvalue (expr, ccomma);
+                       set_cvalue (expr, new CCodeIdentifier (temp_decl.name));
                        return;
                }