Optimization: DelayUser::Id constructor copied user pointers (#1800)

Detected by Coverity. CID 1529593: Unnecessary object copies can affect
performance (COPY_INSTEAD_OF_MOVE).

diff --git a/src/DelayUser.cc b/src/DelayUser.cc
index 40892340aa723195a285c98a2cb50959e7a42cc3..b6d2ca209b4b832ee0a62a188cd6fc3e72687f45 100644 (file)
--- a/src/DelayUser.cc
+++ b/src/DelayUser.cc
@@ -139,7 +139,7 @@ DelayUserBucket::stats (StoreEntry *entry) const
     theBucket.stats(entry);
 }
 
-DelayUser::Id::Id(DelayUser::Pointer aDelayUser, Auth::User::Pointer aUser) : theUser(aDelayUser)
+DelayUser::Id::Id(const DelayUser::Pointer &aDelayUser, const Auth::User::Pointer &aUser) : theUser(aDelayUser)
 {
     theBucket = new DelayUserBucket(aUser);
     DelayUserBucket::Pointer const *existing = theUser->buckets.find(theBucket, DelayUserCmp);

diff --git a/src/DelayUser.h b/src/DelayUser.h
index c6e4d0db333c11835e8eaf482e9fded664bc94c3..ad52a942a96ffbb5a22ed4b4ee43af9ff863c646 100644 (file)
--- a/src/DelayUser.h
+++ b/src/DelayUser.h
@@ -60,7 +60,7 @@ private:
         MEMPROXY_CLASS(DelayUser::Id);
 
     public:
-        Id(RefCount<DelayUser>, Auth::User::Pointer);
+        Id(const DelayUser::Pointer &, const Auth::User::Pointer &);
         ~Id() override;
         int bytesWanted (int min, int max) const override;
         void bytesIn(int qty) override;