In the fast sanity check for these tools which use shadow memory,

remove the test that the first page of memory is inaccessible.  This
is now getting in the way.

Fixes #69886.

git-svn-id: svn://svn.valgrind.org/valgrind/trunk@2180

diff --git a/addrcheck/ac_main.c b/addrcheck/ac_main.c
index 095837cddf4e27e67542d8ef4f35b0c7499d8646..74acac0cc2c0c1c415d9f8cf724939102eefb021 100644 (file)
--- a/addrcheck/ac_main.c
+++ b/addrcheck/ac_main.c
@@ -1142,23 +1142,10 @@ static void ac_detect_memory_leaks ( void )
    Sanity check machinery (permanently engaged).
    ------------------------------------------------------------------ */
 
-/* Check that nobody has spuriously claimed that the first or last 16
-   pages (64 KB) of address space have become accessible.  Failure of
-   the following do not per se indicate an internal consistency
-   problem, but they are so likely to that we really want to know
-   about it if so. */
-
 Bool SK_(cheap_sanity_check) ( void )
 {
-   if (IS_DISTINGUISHED_SM(primary_map[0])
-       /* kludge: kernel drops a page up at top of address range for
-          magic "optimized syscalls", so we can no longer check the
-          highest page */
-       /* && IS_DISTINGUISHED_SM(primary_map[65535]) */
-      )
-      return True;
-   else
-      return False;
+   /* nothing useful we can rapidly check */
+   return True;
 }
 
 Bool SK_(expensive_sanity_check) ( void )

diff --git a/helgrind/hg_main.c b/helgrind/hg_main.c
index 1964ed9cd76a675c0790eb7f1f2e6a9b26f0be05..9895b87a5d846cea40890b0b4367b7c4f25bf023 100644 (file)
--- a/helgrind/hg_main.c
+++ b/helgrind/hg_main.c
@@ -2000,26 +2000,12 @@ void* SK_(realloc) ( void* p, Int new_size )
 /*--- Machinery to support sanity checking                   ---*/
 /*--------------------------------------------------------------*/
 
-/* Check that nobody has spuriously claimed that the first or last 16
-   pages (64 KB) of address space have become accessible.  Failure of
-   the following do not per se indicate an internal consistency
-   problem, but they are so likely to that we really want to know
-   about it if so. */
-
 Bool SK_(cheap_sanity_check) ( void )
 {
-   if (VGE_IS_DISTINGUISHED_SM(primary_map[0])
-       /* kludge: kernel drops a page up at top of address range for
-          magic "optimized syscalls", so we can no longer check the
-          highest page */
-       /* && VGE_IS_DISTINGUISHED_SM(primary_map[65535]) */
-      )
-      return True;
-   else
-      return False;
+   /* nothing useful we can rapidly check */
+   return True;
 }
 
-
 Bool SK_(expensive_sanity_check)(void)
 {
    Int i;

diff --git a/memcheck/mc_main.c b/memcheck/mc_main.c
index 06e72ae32cdb197a69e256a628d2d8477fe0b926..7ee467c05f519e195c65e03ff0baceb64fd58e62 100644 (file)
--- a/memcheck/mc_main.c
+++ b/memcheck/mc_main.c
@@ -1468,23 +1468,10 @@ void MC_(detect_memory_leaks) ( void )
    Sanity check machinery (permanently engaged).
    ------------------------------------------------------------------ */
 
-/* Check that nobody has spuriously claimed that the first or last 16
-   pages (64 KB) of address space have become accessible.  Failure of
-   the following do not per se indicate an internal consistency
-   problem, but they are so likely to that we really want to know
-   about it if so. */
-
 Bool SK_(cheap_sanity_check) ( void )
 {
-   if (IS_DISTINGUISHED_SM(primary_map[0])
-       /* kludge: kernel drops a page up at top of address range for
-          magic "optimized syscalls", so we can no longer check the
-          highest page */
-       /* && IS_DISTINGUISHED_SM(primary_map[65535]) */
-      )
-      return True;
-   else
-      return False;
+   /* nothing useful we can rapidly check */
+   return True;
 }
 
 Bool SK_(expensive_sanity_check) ( void )