]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
power: supply: sbs-manager: normalize return value of gpio_get
authorDmitry Torokhov <dmitry.torokhov@gmail.com>
Wed, 18 Feb 2026 20:59:49 +0000 (12:59 -0800)
committerSebastian Reichel <sebastian.reichel@collabora.com>
Tue, 3 Mar 2026 22:58:07 +0000 (23:58 +0100)
The GPIO get callback is expected to return 0 or 1 (or a negative error
code). Ensure that the value returned by sbsm_gpio_get_value() is
normalized to the [0, 1] range.

Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Reviewed-by: Linus Walleij <linusw@kernel.org>
Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Link: https://patch.msgid.link/aZYoL2MnTYU5FuQh@google.com
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
drivers/power/supply/sbs-manager.c

index 6fe526222f7f4dc28c59006a1040f9f3a4f599d2..343ad4ab4082c5c8df3c1eb2cb22baf3e3c26c17 100644 (file)
@@ -199,7 +199,7 @@ static int sbsm_gpio_get_value(struct gpio_chip *gc, unsigned int off)
        if (ret < 0)
                return ret;
 
-       return ret & BIT(off);
+       return !!(ret & BIT(off));
 }
 
 /*