Use of 'filter' in keybindingDialog.py was causing

custom key assignment to fail.
  Patch 5707 amaury.forgeotdarc.

diff --git a/Lib/idlelib/NEWS.txt b/Lib/idlelib/NEWS.txt
index c111232c842447558dff0e8d804f70c379298a1a..2918fe5e3000af9a716d6271da0b99b1820f1ed2 100644 (file)
--- a/Lib/idlelib/NEWS.txt
+++ b/Lib/idlelib/NEWS.txt
@@ -3,6 +3,9 @@ What's New in IDLE 3.1b1?
 
 *Release date: XX-XXX-09*
 
+- Use of 'filter' in keybindingDialog.py was causing custom key assignment to
+  fail.  Patch 5707 amaury.forgeotdarc.
+
 
 What's New in IDLE 3.1a1?
 =========================

diff --git a/Lib/idlelib/keybindingDialog.py b/Lib/idlelib/keybindingDialog.py
index b99c5e0d8c0b51866801fcaea4ca3806ffd27b94..0f0da8c7e930d953f906e380e4296d437c60ecfb 100644 (file)
--- a/Lib/idlelib/keybindingDialog.py
+++ b/Lib/idlelib/keybindingDialog.py
@@ -168,7 +168,7 @@ class GetKeysDialog(Toplevel):
 
     def GetModifiers(self):
         modList = [variable.get() for variable in self.modifier_vars]
-        return filter(None, modList)
+        return [mod for mod in modList if mod]
 
     def ClearKeySeq(self):
         self.listKeysFinal.select_clear(0,END)