]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
power: sequencing: pcie-m2: Fix device node reference leak in probe
authorFelix Gu <ustc.gu@gmail.com>
Mon, 2 Mar 2026 14:31:44 +0000 (22:31 +0800)
committerBartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Wed, 4 Mar 2026 08:16:41 +0000 (09:16 +0100)
In pwrseq_pcie_m2_probe(), ctx->of_node acquires an explicit reference
to the device node using of_node_get(), but there is no corresponding
of_node_put() in the driver's error handling paths or removal.

Since the ctx is tied to the lifecycle of the platform device, there
is no need to hold an additional reference to the device's own of_node.

Fixes: 52e7b5bd62ba ("power: sequencing: Add the Power Sequencing driver for the PCIe M.2 connectors")
Signed-off-by: Felix Gu <ustc.gu@gmail.com>
Link: https://patch.msgid.link/20260302-m2-v1-1-a6533e18aa69@gmail.com
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
drivers/power/sequencing/pwrseq-pcie-m2.c

index d31a7dd8b35c24636664c200b8b57d82b965db74..dadb4aad9d5d4c59312cb25675118873dddb376e 100644 (file)
@@ -109,7 +109,7 @@ static int pwrseq_pcie_m2_probe(struct platform_device *pdev)
        if (!ctx)
                return -ENOMEM;
 
-       ctx->of_node = of_node_get(dev->of_node);
+       ctx->of_node = dev_of_node(dev);
        ctx->pdata = device_get_match_data(dev);
        if (!ctx->pdata)
                return dev_err_probe(dev, -ENODEV,