]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
virtio_ring: fix return code on DMA mapping fails
authorHalil Pasic <pasic@linux.ibm.com>
Thu, 14 Nov 2019 12:46:46 +0000 (13:46 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 1 Dec 2019 08:17:40 +0000 (09:17 +0100)
[ Upstream commit f7728002c1c7bfa787b276a31c3ef458739b8e7c ]

Commit 780bc7903a32 ("virtio_ring: Support DMA APIs")  makes
virtqueue_add() return -EIO when we fail to map our I/O buffers. This is
a very realistic scenario for guests with encrypted memory, as swiotlb
may run out of space, depending on it's size and the I/O load.

The virtio-blk driver interprets -EIO form virtqueue_add() as an IO
error, despite the fact that swiotlb full is in absence of bugs a
recoverable condition.

Let us change the return code to -ENOMEM, and make the block layer
recover form these failures when virtio-blk encounters the condition
described above.

Cc: stable@vger.kernel.org
Fixes: 780bc7903a32 ("virtio_ring: Support DMA APIs")
Signed-off-by: Halil Pasic <pasic@linux.ibm.com>
Tested-by: Michael Mueller <mimu@linux.ibm.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/virtio/virtio_ring.c

index 9529e28e18222ee8e6d5dc24ddc99d979fca26e0..6228b48d1e1277fa149735f2eb2d3a6189da011b 100644 (file)
@@ -431,7 +431,7 @@ unmap_release:
                kfree(desc);
 
        END_USE(vq);
-       return -EIO;
+       return -ENOMEM;
 }
 
 /**