Bug 1978: fwdServerClose retries non-idempotent methods

checkRetry is now guaranteed to return false for requests that checkRetriable
previously returned false. This prevents retries of requests with
non-idempotent methods, for example.

diff --git a/src/forward.cc b/src/forward.cc
index ce47ad6133185627a9329fa4ef9ef563a1c9fe67..c646951e09700e89088465e43989b33b955bf500 100644 (file)
--- a/src/forward.cc
+++ b/src/forward.cc
@@ -1,6 +1,6 @@
 
 /*
- * $Id: forward.cc,v 1.173 2008/02/07 06:07:24 rousskov Exp $
+ * $Id: forward.cc,v 1.174 2008/02/07 18:22:23 rousskov Exp $
  *
  * DEBUG: section 17    Request Forwarding
  * AUTHOR: Duane Wessels
@@ -439,6 +439,9 @@ FwdState::checkRetry()
     if (flags.dont_retry)
         return false;
 
+    if (!checkRetriable())
+        return false;
+
     if (request->bodyNibbled())
         return false;