]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
drm/amdgpu: amdgpu_ttm_gart_bind set gtt bound flag
authorPhilip Yang <Philip.Yang@amd.com>
Mon, 11 Mar 2024 22:07:34 +0000 (18:07 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 10 Apr 2024 14:18:43 +0000 (16:18 +0200)
[ Upstream commit 6c6064cbe58b43533e3451ad6a8ba9736c109ac3 ]

Otherwise after the GTT bo is released, the GTT and gart space is freed
but amdgpu_ttm_backend_unbind will not clear the gart page table entry
and leave valid mapping entry pointing to the stale system page. Then
if GPU access the gart address mistakely, it will read undefined value
instead page fault, harder to debug and reproduce the real issue.

Cc: stable@vger.kernel.org
Signed-off-by: Philip Yang <Philip.Yang@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c

index b06fb1fa411b42191f1e4610b5a53342a9841957..9a1b19e3d4378981299bf875d4941b603db96c19 100644 (file)
@@ -859,6 +859,7 @@ static int amdgpu_ttm_gart_bind(struct amdgpu_device *adev,
                r = amdgpu_gart_bind(adev, gtt->offset, ttm->num_pages,
                                     gtt->ttm.dma_address, flags);
        }
+       gtt->bound = true;
 
 gart_bind_fail:
        if (r)