]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
mm/damon/reclaim: avoid divide-by-zero in damon_reclaim_apply_parameters()
authorQuanmin Yan <yanquanmin1@huawei.com>
Wed, 27 Aug 2025 11:58:58 +0000 (19:58 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 19 Sep 2025 14:35:47 +0000 (16:35 +0200)
commit e6b543ca9806d7bced863f43020e016ee996c057 upstream.

When creating a new scheme of DAMON_RECLAIM, the calculation of
'min_age_region' uses 'aggr_interval' as the divisor, which may lead to
division-by-zero errors.  Fix it by directly returning -EINVAL when such a
case occurs.

Link: https://lkml.kernel.org/r/20250827115858.1186261-3-yanquanmin1@huawei.com
Fixes: f5a79d7c0c87 ("mm/damon: introduce struct damos_access_pattern")
Signed-off-by: Quanmin Yan <yanquanmin1@huawei.com>
Reviewed-by: SeongJae Park <sj@kernel.org>
Cc: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: ze zuo <zuoze1@huawei.com>
Cc: <stable@vger.kernel.org> [6.1+]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: SeongJae Park <sj@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
mm/damon/reclaim.c

index 9e0077a9404e2ce64ff7142938e0536687dc7b60..65842e6854fd1d86c8febcde947f59dd9de139aa 100644 (file)
@@ -194,6 +194,11 @@ static int damon_reclaim_apply_parameters(void)
        if (err)
                return err;
 
+       if (!damon_reclaim_mon_attrs.aggr_interval) {
+               err = -EINVAL;
+               goto out;
+       }
+
        err = damon_set_attrs(ctx, &damon_reclaim_mon_attrs);
        if (err)
                goto out;