but only close the new conn if one of the earlier helper nodes

that we mark up is actually reachable, fast enough, etc to use.

svn:r5672

diff --git a/src/or/circuitbuild.c b/src/or/circuitbuild.c
index 154f687f59e1f328409fa86c2718a2c9978ae209..f19f1d77084e469fc1f4488d7f221d5ab61b1a4e 100644 (file)
--- a/src/or/circuitbuild.c
+++ b/src/or/circuitbuild.c
@@ -1959,11 +1959,14 @@ helper_node_set_status(const char *digest, int succeeded)
             helper->made_contact = 1;
             SMARTLIST_FOREACH(helper_nodes, helper_node_t *, h,
               {
-                routerinfo_t *r = router_get_by_digest(h->identity);
+                routerinfo_t *r;
                 if (h->made_contact) {
                   h->down_since = 0;
-                  refuse_conn = 1;
-                  if (r) r->is_running = 1;
+                  r = helper_is_live(h, 0, 1);
+                  if (r) {
+                    refuse_conn = 1;
+                    r->is_running = 1;
+                  }
                 }
                 if (h == helper)
                   break;