]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
rsi: release skb if rsi_prepare_beacon fails
authorNavid Emamdoost <navid.emamdoost@gmail.com>
Sat, 14 Sep 2019 00:08:11 +0000 (19:08 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 13 Dec 2019 07:50:57 +0000 (08:50 +0100)
commit d563131ef23cbc756026f839a82598c8445bc45f upstream.

In rsi_send_beacon, if rsi_prepare_beacon fails the allocated skb should
be released.

Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/wireless/rsi/rsi_91x_mgmt.c

index 1095df7d957350f20b218bd32c8dadb30d3d9153..1a3a5235cfb8d4ae0c86a7f6959431f886efc126 100644 (file)
@@ -1583,6 +1583,7 @@ static int rsi_send_beacon(struct rsi_common *common)
                skb_pull(skb, (64 - dword_align_bytes));
        if (rsi_prepare_beacon(common, skb)) {
                rsi_dbg(ERR_ZONE, "Failed to prepare beacon\n");
+               dev_kfree_skb(skb);
                return -EINVAL;
        }
        skb_queue_tail(&common->tx_queue[MGMT_BEACON_Q], skb);