aarch64: backport fix for PR target/94530

gcc/ChangeLog

2020-04-16  Andrea Corallo  <andrea.corallo@arm.com>

	Backport from mainline.
	2020-04-15  Andrea Corallo  <andrea.corallo@arm.com

	PR target/94530
	* config/aarch64/falkor-tag-collision-avoidance.c
	(valid_src_p): Check for aarch64_address_info type before
	accessing base field.

gcc/testsuite/ChangeLog

2020-04-16  Andrea Corallo  <andrea.corallo@arm.com>

	Backport from mainline.
	2020-04-09  Andrea Corallo  <andrea.corallo@arm.com>

	PR target/94530
	* gcc.target/aarch64/pr94530.c: New test.

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 4b29a54e90a54eb3228e2fb9558eac9d93172d87..4222eed2d9be9fc44594f2aa604e808e65ec5920 100644 (file)
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,13 @@
+2020-04-20  Andrea Corallo  <andrea.corallo@arm.com>
+
+       Backport from mainline.
+       2020-04-15  Andrea Corallo  <andrea.corallo@arm.com>
+
+       PR target/94530
+       * config/aarch64/falkor-tag-collision-avoidance.c
+       (valid_src_p): Check for aarch64_address_info type before
+       accessing base field.
+
 2020-04-20  Tamar Christina  <tamar.christina@arm.com>
 
        Backport from mainline.

diff --git a/gcc/config/aarch64/falkor-tag-collision-avoidance.c b/gcc/config/aarch64/falkor-tag-collision-avoidance.c
index 779dee81f7f4ed3d3ae1fc11f232fc558027b9fe..698d1595d0a6a3ae028d9280615673a03613123a 100644 (file)
--- a/gcc/config/aarch64/falkor-tag-collision-avoidance.c
+++ b/gcc/config/aarch64/falkor-tag-collision-avoidance.c
@@ -537,6 +537,13 @@ valid_src_p (rtx src, rtx_insn *insn, struct loop *loop, bool *pre_post,
   if (!aarch64_classify_address (&addr, XEXP (x, 0), mode, true))
     return false;
 
+  if (addr.type != ADDRESS_REG_IMM
+      && addr.type != ADDRESS_REG_WB
+      && addr.type != ADDRESS_REG_REG
+      && addr.type != ADDRESS_REG_UXTW
+      && addr.type != ADDRESS_REG_SXTW)
+    return false;
+
   unsigned regno = REGNO (addr.base);
   if (global_regs[regno] || fixed_regs[regno])
     return false;

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 5a52e97da05f6d5d6b708b01990f38a4e14be857..d0117119d4b86e0f3f8804f4bb94b61ed736067c 100644 (file)
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,11 @@
+2020-04-20  Andrea Corallo  <andrea.corallo@arm.com>
+
+       Backport from mainline.
+       2020-04-09  Andrea Corallo  <andrea.corallo@arm.com
+
+       PR target/94530
+       * gcc.target/aarch64/pr94530.c: New test.
+
 2020-04-20  Tamar Christina  <tamar.christina@arm.com>
 
        Backport from mainline.

diff --git a/gcc/testsuite/gcc.target/aarch64/pr94530.c b/gcc/testsuite/gcc.target/aarch64/pr94530.c
new file mode 100644 (file)
index 0000000..1f98201
--- /dev/null
+++ b/gcc/testsuite/gcc.target/aarch64/pr94530.c
@@ -0,0 +1,9 @@
+/* { dg-do compile } */
+/* { dg-options "-Os -mcpu=falkor -mpc-relative-literal-loads -mcmodel=large" } */
+
+extern void bar(const char *);
+
+void foo(void) {
+  for (;;)
+    bar("");
+}