]> git.ipfire.org Git - thirdparty/kernel/stable-queue.git/commitdiff
Fixes for 4.19
authorSasha Levin <sashal@kernel.org>
Sun, 17 Jul 2022 14:52:39 +0000 (10:52 -0400)
committerSasha Levin <sashal@kernel.org>
Sun, 17 Jul 2022 14:52:39 +0000 (10:52 -0400)
Signed-off-by: Sasha Levin <sashal@kernel.org>
17 files changed:
queue-4.19/arm-9209-1-spectre-bhb-avoid-pr_info-every-time-a-cp.patch [new file with mode: 0644]
queue-4.19/arm-dts-imx6qdl-ts7970-fix-ngpio-typo-and-count.patch [new file with mode: 0644]
queue-4.19/arm-dts-sunxi-fix-spi-nor-campatible-on-orange-pi-ze.patch [new file with mode: 0644]
queue-4.19/asoc-sgtl5000-fix-noise-on-shutdown-remove.patch [new file with mode: 0644]
queue-4.19/cipso-fix-data-races-around-sysctl.patch [new file with mode: 0644]
queue-4.19/icmp-fix-a-data-race-around-sysctl_icmp_ratelimit.patch [new file with mode: 0644]
queue-4.19/icmp-fix-a-data-race-around-sysctl_icmp_ratemask.patch [new file with mode: 0644]
queue-4.19/icmp-fix-data-races-around-sysctl.patch [new file with mode: 0644]
queue-4.19/inetpeer-fix-data-races-around-sysctl.patch [new file with mode: 0644]
queue-4.19/ipv4-fix-data-races-around-sysctl_ip_dynaddr.patch [new file with mode: 0644]
queue-4.19/net-fix-data-races-around-sysctl_mem.patch [new file with mode: 0644]
queue-4.19/seg6-bpf-fix-skb-checksum-in-bpf_push_seg6_encap.patch [new file with mode: 0644]
queue-4.19/seg6-fix-skb-checksum-evaluation-in-srh-encapsulatio.patch [new file with mode: 0644]
queue-4.19/seg6-fix-skb-checksum-in-srv6-end.b6-and-end.b6.enca.patch [new file with mode: 0644]
queue-4.19/series
queue-4.19/sfc-fix-kernel-panic-when-creating-vf.patch [new file with mode: 0644]
queue-4.19/sfc-fix-use-after-free-when-disabling-sriov.patch [new file with mode: 0644]

diff --git a/queue-4.19/arm-9209-1-spectre-bhb-avoid-pr_info-every-time-a-cp.patch b/queue-4.19/arm-9209-1-spectre-bhb-avoid-pr_info-every-time-a-cp.patch
new file mode 100644 (file)
index 0000000..7b603b3
--- /dev/null
@@ -0,0 +1,58 @@
+From b09df09629c7cf503ca2790d5ce26bf08613f730 Mon Sep 17 00:00:00 2001
+From: Sasha Levin <sashal@kernel.org>
+Date: Tue, 31 May 2022 09:53:42 +0100
+Subject: ARM: 9209/1: Spectre-BHB: avoid pr_info() every time a CPU comes out
+ of idle
+
+From: Ard Biesheuvel <ardb@kernel.org>
+
+[ Upstream commit 0609e200246bfd3b7516091c491bec4308349055 ]
+
+Jon reports that the Spectre-BHB init code is filling up the kernel log
+with spurious notifications about which mitigation has been enabled,
+every time any CPU comes out of a low power state.
+
+Given that Spectre-BHB mitigations are system wide, only a single
+mitigation can be enabled, and we already print an error if two types of
+CPUs coexist in a single system that require different Spectre-BHB
+mitigations.
+
+This means that the pr_info() that describes the selected mitigation
+does not need to be emitted for each CPU anyway, and so we can simply
+emit it only once.
+
+In order to clarify the above in the log message, update it to describe
+that the selected mitigation will be enabled on all CPUs, including ones
+that are unaffected. If another CPU comes up later that is affected and
+requires a different mitigation, we report an error as before.
+
+Fixes: b9baf5c8c5c3 ("ARM: Spectre-BHB workaround")
+Tested-by: Jon Hunter <jonathanh@nvidia.com>
+Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
+Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
+Signed-off-by: Sasha Levin <sashal@kernel.org>
+---
+ arch/arm/mm/proc-v7-bugs.c | 6 +++---
+ 1 file changed, 3 insertions(+), 3 deletions(-)
+
+diff --git a/arch/arm/mm/proc-v7-bugs.c b/arch/arm/mm/proc-v7-bugs.c
+index 40fb2900038e..e53f824a2583 100644
+--- a/arch/arm/mm/proc-v7-bugs.c
++++ b/arch/arm/mm/proc-v7-bugs.c
+@@ -222,10 +222,10 @@ static int spectre_bhb_install_workaround(int method)
+                       return SPECTRE_VULNERABLE;
+               spectre_bhb_method = method;
+-      }
+-      pr_info("CPU%u: Spectre BHB: using %s workaround\n",
+-              smp_processor_id(), spectre_bhb_method_name(method));
++              pr_info("CPU%u: Spectre BHB: enabling %s workaround for all CPUs\n",
++                      smp_processor_id(), spectre_bhb_method_name(method));
++      }
+       return SPECTRE_MITIGATED;
+ }
+-- 
+2.35.1
+
diff --git a/queue-4.19/arm-dts-imx6qdl-ts7970-fix-ngpio-typo-and-count.patch b/queue-4.19/arm-dts-imx6qdl-ts7970-fix-ngpio-typo-and-count.patch
new file mode 100644 (file)
index 0000000..a158f66
--- /dev/null
@@ -0,0 +1,39 @@
+From c3e96482add443ae96fdf15507f88b0c1a9a05c7 Mon Sep 17 00:00:00 2001
+From: Sasha Levin <sashal@kernel.org>
+Date: Thu, 30 Jun 2022 14:03:27 -0700
+Subject: ARM: dts: imx6qdl-ts7970: Fix ngpio typo and count
+
+From: Kris Bahnsen <kris@embeddedTS.com>
+
+[ Upstream commit e95ea0f687e679fcb0a3a67d0755b81ee7d60db0 ]
+
+Device-tree incorrectly used "ngpio" which caused the driver to
+fallback to 32 ngpios.
+
+This platform has 62 GPIO registers.
+
+Fixes: 9ff8e9fccef9 ("ARM: dts: TS-7970: add basic device tree")
+Signed-off-by: Kris Bahnsen <kris@embeddedTS.com>
+Reviewed-by: Fabio Estevam <festevam@gmail.com>
+Signed-off-by: Shawn Guo <shawnguo@kernel.org>
+Signed-off-by: Sasha Levin <sashal@kernel.org>
+---
+ arch/arm/boot/dts/imx6qdl-ts7970.dtsi | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/arch/arm/boot/dts/imx6qdl-ts7970.dtsi b/arch/arm/boot/dts/imx6qdl-ts7970.dtsi
+index f0be516dc28e..9181fbeb833d 100644
+--- a/arch/arm/boot/dts/imx6qdl-ts7970.dtsi
++++ b/arch/arm/boot/dts/imx6qdl-ts7970.dtsi
+@@ -226,7 +226,7 @@ gpio8: gpio@28 {
+               reg = <0x28>;
+               #gpio-cells = <2>;
+               gpio-controller;
+-              ngpio = <32>;
++              ngpios = <62>;
+       };
+       sgtl5000: codec@a {
+-- 
+2.35.1
+
diff --git a/queue-4.19/arm-dts-sunxi-fix-spi-nor-campatible-on-orange-pi-ze.patch b/queue-4.19/arm-dts-sunxi-fix-spi-nor-campatible-on-orange-pi-ze.patch
new file mode 100644 (file)
index 0000000..7a78834
--- /dev/null
@@ -0,0 +1,40 @@
+From f09366d8c75c7b65f3755456f957cd0abb5ca28e Mon Sep 17 00:00:00 2001
+From: Sasha Levin <sashal@kernel.org>
+Date: Fri, 8 Jul 2022 19:45:29 +0200
+Subject: ARM: dts: sunxi: Fix SPI NOR campatible on Orange Pi Zero
+
+From: Michal Suchanek <msuchanek@suse.de>
+
+[ Upstream commit 884b66976a7279ee889ba885fe364244d50b79e7 ]
+
+The device tree should include generic "jedec,spi-nor" compatible, and a
+manufacturer-specific one.
+The macronix part is what is shipped on the boards that come with a
+flash chip.
+
+Fixes: 45857ae95478 ("ARM: dts: orange-pi-zero: add node for SPI NOR")
+Signed-off-by: Michal Suchanek <msuchanek@suse.de>
+Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>
+Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com>
+Link: https://lore.kernel.org/r/20220708174529.3360-1-msuchanek@suse.de
+Signed-off-by: Sasha Levin <sashal@kernel.org>
+---
+ arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts b/arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts
+index 84cd9c061227..afc94dbc0752 100644
+--- a/arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts
++++ b/arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts
+@@ -170,7 +170,7 @@ &spi0 {
+       flash@0 {
+               #address-cells = <1>;
+               #size-cells = <1>;
+-              compatible = "mxicy,mx25l1606e", "winbond,w25q128";
++              compatible = "mxicy,mx25l1606e", "jedec,spi-nor";
+               reg = <0>;
+               spi-max-frequency = <40000000>;
+       };
+-- 
+2.35.1
+
diff --git a/queue-4.19/asoc-sgtl5000-fix-noise-on-shutdown-remove.patch b/queue-4.19/asoc-sgtl5000-fix-noise-on-shutdown-remove.patch
new file mode 100644 (file)
index 0000000..7cd07b1
--- /dev/null
@@ -0,0 +1,79 @@
+From 9d90d601b03cc3b4cae7aa923020bd1d2ba59df4 Mon Sep 17 00:00:00 2001
+From: Sasha Levin <sashal@kernel.org>
+Date: Fri, 24 Jun 2022 12:13:01 +0200
+Subject: ASoC: sgtl5000: Fix noise on shutdown/remove
+
+From: Francesco Dolcini <francesco.dolcini@toradex.com>
+
+[ Upstream commit 040e3360af3736348112d29425bf5d0be5b93115 ]
+
+Put the SGTL5000 in a silent/safe state on shutdown/remove, this is
+required since the SGTL5000 produces a constant noise on its output
+after it is configured and its clock is removed. Without this change
+this is happening every time the module is unbound/removed or from
+reboot till the clock is enabled again.
+
+The issue was experienced on both a Toradex Colibri/Apalis iMX6, but can
+be easily reproduced everywhere just playing something on the codec and
+after that removing/unbinding the driver.
+
+Fixes: 9b34e6cc3bc2 ("ASoC: Add Freescale SGTL5000 codec support")
+Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
+Reviewed-by: Fabio Estevam <festevam@denx.de>
+Link: https://lore.kernel.org/r/20220624101301.441314-1-francesco.dolcini@toradex.com
+Signed-off-by: Mark Brown <broonie@kernel.org>
+Signed-off-by: Sasha Levin <sashal@kernel.org>
+---
+ sound/soc/codecs/sgtl5000.c | 9 +++++++++
+ sound/soc/codecs/sgtl5000.h | 1 +
+ 2 files changed, 10 insertions(+)
+
+diff --git a/sound/soc/codecs/sgtl5000.c b/sound/soc/codecs/sgtl5000.c
+index 17255e9683f5..13e752f8b3f7 100644
+--- a/sound/soc/codecs/sgtl5000.c
++++ b/sound/soc/codecs/sgtl5000.c
+@@ -1769,6 +1769,9 @@ static int sgtl5000_i2c_remove(struct i2c_client *client)
+ {
+       struct sgtl5000_priv *sgtl5000 = i2c_get_clientdata(client);
++      regmap_write(sgtl5000->regmap, SGTL5000_CHIP_DIG_POWER, SGTL5000_DIG_POWER_DEFAULT);
++      regmap_write(sgtl5000->regmap, SGTL5000_CHIP_ANA_POWER, SGTL5000_ANA_POWER_DEFAULT);
++
+       clk_disable_unprepare(sgtl5000->mclk);
+       regulator_bulk_disable(sgtl5000->num_supplies, sgtl5000->supplies);
+       regulator_bulk_free(sgtl5000->num_supplies, sgtl5000->supplies);
+@@ -1776,6 +1779,11 @@ static int sgtl5000_i2c_remove(struct i2c_client *client)
+       return 0;
+ }
++static void sgtl5000_i2c_shutdown(struct i2c_client *client)
++{
++      sgtl5000_i2c_remove(client);
++}
++
+ static const struct i2c_device_id sgtl5000_id[] = {
+       {"sgtl5000", 0},
+       {},
+@@ -1796,6 +1804,7 @@ static struct i2c_driver sgtl5000_i2c_driver = {
+                  },
+       .probe = sgtl5000_i2c_probe,
+       .remove = sgtl5000_i2c_remove,
++      .shutdown = sgtl5000_i2c_shutdown,
+       .id_table = sgtl5000_id,
+ };
+diff --git a/sound/soc/codecs/sgtl5000.h b/sound/soc/codecs/sgtl5000.h
+index 066517e352a7..0ed4bad92cd1 100644
+--- a/sound/soc/codecs/sgtl5000.h
++++ b/sound/soc/codecs/sgtl5000.h
+@@ -80,6 +80,7 @@
+ /*
+  * SGTL5000_CHIP_DIG_POWER
+  */
++#define SGTL5000_DIG_POWER_DEFAULT            0x0000
+ #define SGTL5000_ADC_EN                               0x0040
+ #define SGTL5000_DAC_EN                               0x0020
+ #define SGTL5000_DAP_POWERUP                  0x0010
+-- 
+2.35.1
+
diff --git a/queue-4.19/cipso-fix-data-races-around-sysctl.patch b/queue-4.19/cipso-fix-data-races-around-sysctl.patch
new file mode 100644 (file)
index 0000000..b2e5fae
--- /dev/null
@@ -0,0 +1,95 @@
+From a0c6ebfff6349484f362fbf54486a9c942f49728 Mon Sep 17 00:00:00 2001
+From: Sasha Levin <sashal@kernel.org>
+Date: Wed, 6 Jul 2022 16:40:01 -0700
+Subject: cipso: Fix data-races around sysctl.
+
+From: Kuniyuki Iwashima <kuniyu@amazon.com>
+
+[ Upstream commit dd44f04b9214adb68ef5684ae87a81ba03632250 ]
+
+While reading cipso sysctl variables, they can be changed concurrently.
+So, we need to add READ_ONCE() to avoid data-races.
+
+Fixes: 446fda4f2682 ("[NetLabel]: CIPSOv4 engine")
+Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
+Acked-by: Paul Moore <paul@paul-moore.com>
+Signed-off-by: David S. Miller <davem@davemloft.net>
+Signed-off-by: Sasha Levin <sashal@kernel.org>
+---
+ Documentation/networking/ip-sysctl.txt |  2 +-
+ net/ipv4/cipso_ipv4.c                  | 12 +++++++-----
+ 2 files changed, 8 insertions(+), 6 deletions(-)
+
+diff --git a/Documentation/networking/ip-sysctl.txt b/Documentation/networking/ip-sysctl.txt
+index 3c617d620b6f..ae56957f51e4 100644
+--- a/Documentation/networking/ip-sysctl.txt
++++ b/Documentation/networking/ip-sysctl.txt
+@@ -810,7 +810,7 @@ cipso_cache_enable - BOOLEAN
+ cipso_cache_bucket_size - INTEGER
+       The CIPSO label cache consists of a fixed size hash table with each
+       hash bucket containing a number of cache entries.  This variable limits
+-      the number of entries in each hash bucket; the larger the value the
++      the number of entries in each hash bucket; the larger the value is, the
+       more CIPSO label mappings that can be cached.  When the number of
+       entries in a given hash bucket reaches this limit adding new entries
+       causes the oldest entry in the bucket to be removed to make room.
+diff --git a/net/ipv4/cipso_ipv4.c b/net/ipv4/cipso_ipv4.c
+index e8b8dd1cb157..8dcf9aec7b77 100644
+--- a/net/ipv4/cipso_ipv4.c
++++ b/net/ipv4/cipso_ipv4.c
+@@ -254,7 +254,7 @@ static int cipso_v4_cache_check(const unsigned char *key,
+       struct cipso_v4_map_cache_entry *prev_entry = NULL;
+       u32 hash;
+-      if (!cipso_v4_cache_enabled)
++      if (!READ_ONCE(cipso_v4_cache_enabled))
+               return -ENOENT;
+       hash = cipso_v4_map_cache_hash(key, key_len);
+@@ -311,13 +311,14 @@ static int cipso_v4_cache_check(const unsigned char *key,
+ int cipso_v4_cache_add(const unsigned char *cipso_ptr,
+                      const struct netlbl_lsm_secattr *secattr)
+ {
++      int bkt_size = READ_ONCE(cipso_v4_cache_bucketsize);
+       int ret_val = -EPERM;
+       u32 bkt;
+       struct cipso_v4_map_cache_entry *entry = NULL;
+       struct cipso_v4_map_cache_entry *old_entry = NULL;
+       u32 cipso_ptr_len;
+-      if (!cipso_v4_cache_enabled || cipso_v4_cache_bucketsize <= 0)
++      if (!READ_ONCE(cipso_v4_cache_enabled) || bkt_size <= 0)
+               return 0;
+       cipso_ptr_len = cipso_ptr[1];
+@@ -337,7 +338,7 @@ int cipso_v4_cache_add(const unsigned char *cipso_ptr,
+       bkt = entry->hash & (CIPSO_V4_CACHE_BUCKETS - 1);
+       spin_lock_bh(&cipso_v4_cache[bkt].lock);
+-      if (cipso_v4_cache[bkt].size < cipso_v4_cache_bucketsize) {
++      if (cipso_v4_cache[bkt].size < bkt_size) {
+               list_add(&entry->list, &cipso_v4_cache[bkt].list);
+               cipso_v4_cache[bkt].size += 1;
+       } else {
+@@ -1214,7 +1215,8 @@ static int cipso_v4_gentag_rbm(const struct cipso_v4_doi *doi_def,
+               /* This will send packets using the "optimized" format when
+                * possible as specified in  section 3.4.2.6 of the
+                * CIPSO draft. */
+-              if (cipso_v4_rbm_optfmt && ret_val > 0 && ret_val <= 10)
++              if (READ_ONCE(cipso_v4_rbm_optfmt) && ret_val > 0 &&
++                  ret_val <= 10)
+                       tag_len = 14;
+               else
+                       tag_len = 4 + ret_val;
+@@ -1617,7 +1619,7 @@ int cipso_v4_validate(const struct sk_buff *skb, unsigned char **option)
+                        * all the CIPSO validations here but it doesn't
+                        * really specify _exactly_ what we need to validate
+                        * ... so, just make it a sysctl tunable. */
+-                      if (cipso_v4_rbm_strictvalid) {
++                      if (READ_ONCE(cipso_v4_rbm_strictvalid)) {
+                               if (cipso_v4_map_lvl_valid(doi_def,
+                                                          tag[3]) < 0) {
+                                       err_offset = opt_iter + 3;
+-- 
+2.35.1
+
diff --git a/queue-4.19/icmp-fix-a-data-race-around-sysctl_icmp_ratelimit.patch b/queue-4.19/icmp-fix-a-data-race-around-sysctl_icmp_ratelimit.patch
new file mode 100644 (file)
index 0000000..efa19ab
--- /dev/null
@@ -0,0 +1,37 @@
+From dfe4794beb5c4fc1bf16386412358ad44a7cec49 Mon Sep 17 00:00:00 2001
+From: Sasha Levin <sashal@kernel.org>
+Date: Mon, 11 Jul 2022 17:15:27 -0700
+Subject: icmp: Fix a data-race around sysctl_icmp_ratelimit.
+
+From: Kuniyuki Iwashima <kuniyu@amazon.com>
+
+[ Upstream commit 2a4eb714841f288cf51c7d942d98af6a8c6e4b01 ]
+
+While reading sysctl_icmp_ratelimit, it can be changed concurrently.
+Thus, we need to add READ_ONCE() to its reader.
+
+Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
+Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
+Signed-off-by: David S. Miller <davem@davemloft.net>
+Signed-off-by: Sasha Levin <sashal@kernel.org>
+---
+ net/ipv4/icmp.c | 3 ++-
+ 1 file changed, 2 insertions(+), 1 deletion(-)
+
+diff --git a/net/ipv4/icmp.c b/net/ipv4/icmp.c
+index 953cc70851cf..eb29da8971e1 100644
+--- a/net/ipv4/icmp.c
++++ b/net/ipv4/icmp.c
+@@ -333,7 +333,8 @@ static bool icmpv4_xrlim_allow(struct net *net, struct rtable *rt,
+       vif = l3mdev_master_ifindex(dst->dev);
+       peer = inet_getpeer_v4(net->ipv4.peers, fl4->daddr, vif, 1);
+-      rc = inet_peer_xrlim_allow(peer, net->ipv4.sysctl_icmp_ratelimit);
++      rc = inet_peer_xrlim_allow(peer,
++                                 READ_ONCE(net->ipv4.sysctl_icmp_ratelimit));
+       if (peer)
+               inet_putpeer(peer);
+ out:
+-- 
+2.35.1
+
diff --git a/queue-4.19/icmp-fix-a-data-race-around-sysctl_icmp_ratemask.patch b/queue-4.19/icmp-fix-a-data-race-around-sysctl_icmp_ratemask.patch
new file mode 100644 (file)
index 0000000..c39ec62
--- /dev/null
@@ -0,0 +1,36 @@
+From 30819006d5ca145eb16b420d165d2073672f5692 Mon Sep 17 00:00:00 2001
+From: Sasha Levin <sashal@kernel.org>
+Date: Mon, 11 Jul 2022 17:15:28 -0700
+Subject: icmp: Fix a data-race around sysctl_icmp_ratemask.
+
+From: Kuniyuki Iwashima <kuniyu@amazon.com>
+
+[ Upstream commit 1ebcb25ad6fc3d50fca87350acf451b9a66dd31e ]
+
+While reading sysctl_icmp_ratemask, it can be changed concurrently.
+Thus, we need to add READ_ONCE() to its reader.
+
+Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
+Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
+Signed-off-by: David S. Miller <davem@davemloft.net>
+Signed-off-by: Sasha Levin <sashal@kernel.org>
+---
+ net/ipv4/icmp.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/net/ipv4/icmp.c b/net/ipv4/icmp.c
+index eb29da8971e1..aa179e6461e1 100644
+--- a/net/ipv4/icmp.c
++++ b/net/ipv4/icmp.c
+@@ -295,7 +295,7 @@ static bool icmpv4_mask_allow(struct net *net, int type, int code)
+               return true;
+       /* Limit if icmp type is enabled in ratemask. */
+-      if (!((1 << type) & net->ipv4.sysctl_icmp_ratemask))
++      if (!((1 << type) & READ_ONCE(net->ipv4.sysctl_icmp_ratemask)))
+               return true;
+       return false;
+-- 
+2.35.1
+
diff --git a/queue-4.19/icmp-fix-data-races-around-sysctl.patch b/queue-4.19/icmp-fix-data-races-around-sysctl.patch
new file mode 100644 (file)
index 0000000..c767e1a
--- /dev/null
@@ -0,0 +1,42 @@
+From e88cca8c74b4bb31b83ade230b701c33cc8cc6ac Mon Sep 17 00:00:00 2001
+From: Sasha Levin <sashal@kernel.org>
+Date: Wed, 6 Jul 2022 16:40:02 -0700
+Subject: icmp: Fix data-races around sysctl.
+
+From: Kuniyuki Iwashima <kuniyu@amazon.com>
+
+[ Upstream commit 48d7ee321ea5182c6a70782aa186422a70e67e22 ]
+
+While reading icmp sysctl variables, they can be changed concurrently.
+So, we need to add READ_ONCE() to avoid data-races.
+
+Fixes: 4cdf507d5452 ("icmp: add a global rate limitation")
+Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
+Signed-off-by: David S. Miller <davem@davemloft.net>
+Signed-off-by: Sasha Levin <sashal@kernel.org>
+---
+ net/ipv4/icmp.c | 5 +++--
+ 1 file changed, 3 insertions(+), 2 deletions(-)
+
+diff --git a/net/ipv4/icmp.c b/net/ipv4/icmp.c
+index fe10a565b7d8..953cc70851cf 100644
+--- a/net/ipv4/icmp.c
++++ b/net/ipv4/icmp.c
+@@ -266,11 +266,12 @@ bool icmp_global_allow(void)
+       spin_lock(&icmp_global.lock);
+       delta = min_t(u32, now - icmp_global.stamp, HZ);
+       if (delta >= HZ / 50) {
+-              incr = sysctl_icmp_msgs_per_sec * delta / HZ ;
++              incr = READ_ONCE(sysctl_icmp_msgs_per_sec) * delta / HZ;
+               if (incr)
+                       WRITE_ONCE(icmp_global.stamp, now);
+       }
+-      credit = min_t(u32, icmp_global.credit + incr, sysctl_icmp_msgs_burst);
++      credit = min_t(u32, icmp_global.credit + incr,
++                     READ_ONCE(sysctl_icmp_msgs_burst));
+       if (credit) {
+               /* We want to use a credit of one in average, but need to randomize
+                * it for security reasons.
+-- 
+2.35.1
+
diff --git a/queue-4.19/inetpeer-fix-data-races-around-sysctl.patch b/queue-4.19/inetpeer-fix-data-races-around-sysctl.patch
new file mode 100644 (file)
index 0000000..a352637
--- /dev/null
@@ -0,0 +1,52 @@
+From fff81cbe072d1a41dc17d5f8b0a1d0e39bce4353 Mon Sep 17 00:00:00 2001
+From: Sasha Levin <sashal@kernel.org>
+Date: Wed, 6 Jul 2022 16:39:59 -0700
+Subject: inetpeer: Fix data-races around sysctl.
+
+From: Kuniyuki Iwashima <kuniyu@amazon.com>
+
+[ Upstream commit 3d32edf1f3c38d3301f6434e56316f293466d7fb ]
+
+While reading inetpeer sysctl variables, they can be changed
+concurrently.  So, we need to add READ_ONCE() to avoid data-races.
+
+Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
+Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
+Signed-off-by: David S. Miller <davem@davemloft.net>
+Signed-off-by: Sasha Levin <sashal@kernel.org>
+---
+ net/ipv4/inetpeer.c | 12 ++++++++----
+ 1 file changed, 8 insertions(+), 4 deletions(-)
+
+diff --git a/net/ipv4/inetpeer.c b/net/ipv4/inetpeer.c
+index ff327a62c9ce..a18668552d33 100644
+--- a/net/ipv4/inetpeer.c
++++ b/net/ipv4/inetpeer.c
+@@ -148,16 +148,20 @@ static void inet_peer_gc(struct inet_peer_base *base,
+                        struct inet_peer *gc_stack[],
+                        unsigned int gc_cnt)
+ {
++      int peer_threshold, peer_maxttl, peer_minttl;
+       struct inet_peer *p;
+       __u32 delta, ttl;
+       int i;
+-      if (base->total >= inet_peer_threshold)
++      peer_threshold = READ_ONCE(inet_peer_threshold);
++      peer_maxttl = READ_ONCE(inet_peer_maxttl);
++      peer_minttl = READ_ONCE(inet_peer_minttl);
++
++      if (base->total >= peer_threshold)
+               ttl = 0; /* be aggressive */
+       else
+-              ttl = inet_peer_maxttl
+-                              - (inet_peer_maxttl - inet_peer_minttl) / HZ *
+-                                      base->total / inet_peer_threshold * HZ;
++              ttl = peer_maxttl - (peer_maxttl - peer_minttl) / HZ *
++                      base->total / peer_threshold * HZ;
+       for (i = 0; i < gc_cnt; i++) {
+               p = gc_stack[i];
+-- 
+2.35.1
+
diff --git a/queue-4.19/ipv4-fix-data-races-around-sysctl_ip_dynaddr.patch b/queue-4.19/ipv4-fix-data-races-around-sysctl_ip_dynaddr.patch
new file mode 100644 (file)
index 0000000..4a74fb2
--- /dev/null
@@ -0,0 +1,59 @@
+From 7f492806885b547e69283787bd72c498d1fc90f0 Mon Sep 17 00:00:00 2001
+From: Sasha Levin <sashal@kernel.org>
+Date: Mon, 11 Jul 2022 17:15:32 -0700
+Subject: ipv4: Fix data-races around sysctl_ip_dynaddr.
+
+From: Kuniyuki Iwashima <kuniyu@amazon.com>
+
+[ Upstream commit e49e4aff7ec19b2d0d0957ee30e93dade57dab9e ]
+
+While reading sysctl_ip_dynaddr, it can be changed concurrently.
+Thus, we need to add READ_ONCE() to its readers.
+
+Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
+Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
+Signed-off-by: David S. Miller <davem@davemloft.net>
+Signed-off-by: Sasha Levin <sashal@kernel.org>
+---
+ Documentation/networking/ip-sysctl.txt | 2 +-
+ net/ipv4/af_inet.c                     | 4 ++--
+ 2 files changed, 3 insertions(+), 3 deletions(-)
+
+diff --git a/Documentation/networking/ip-sysctl.txt b/Documentation/networking/ip-sysctl.txt
+index ae56957f51e4..e315e6052b9f 100644
+--- a/Documentation/networking/ip-sysctl.txt
++++ b/Documentation/networking/ip-sysctl.txt
+@@ -887,7 +887,7 @@ ip_nonlocal_bind - BOOLEAN
+       which can be quite useful - but may break some applications.
+       Default: 0
+-ip_dynaddr - BOOLEAN
++ip_dynaddr - INTEGER
+       If set non-zero, enables support for dynamic addresses.
+       If set to a non-zero value larger than 1, a kernel log
+       message will be printed when dynamic address rewriting
+diff --git a/net/ipv4/af_inet.c b/net/ipv4/af_inet.c
+index d8c22246629a..dadd42a07c07 100644
+--- a/net/ipv4/af_inet.c
++++ b/net/ipv4/af_inet.c
+@@ -1209,7 +1209,7 @@ static int inet_sk_reselect_saddr(struct sock *sk)
+       if (new_saddr == old_saddr)
+               return 0;
+-      if (sock_net(sk)->ipv4.sysctl_ip_dynaddr > 1) {
++      if (READ_ONCE(sock_net(sk)->ipv4.sysctl_ip_dynaddr) > 1) {
+               pr_info("%s(): shifting inet->saddr from %pI4 to %pI4\n",
+                       __func__, &old_saddr, &new_saddr);
+       }
+@@ -1264,7 +1264,7 @@ int inet_sk_rebuild_header(struct sock *sk)
+                * Other protocols have to map its equivalent state to TCP_SYN_SENT.
+                * DCCP maps its DCCP_REQUESTING state to TCP_SYN_SENT. -acme
+                */
+-              if (!sock_net(sk)->ipv4.sysctl_ip_dynaddr ||
++              if (!READ_ONCE(sock_net(sk)->ipv4.sysctl_ip_dynaddr) ||
+                   sk->sk_state != TCP_SYN_SENT ||
+                   (sk->sk_userlocks & SOCK_BINDADDR_LOCK) ||
+                   (err = inet_sk_reselect_saddr(sk)) != 0)
+-- 
+2.35.1
+
diff --git a/queue-4.19/net-fix-data-races-around-sysctl_mem.patch b/queue-4.19/net-fix-data-races-around-sysctl_mem.patch
new file mode 100644 (file)
index 0000000..08bb9fb
--- /dev/null
@@ -0,0 +1,36 @@
+From 77770088fe0025314cc3ca29f735c3a077a0ea1b Mon Sep 17 00:00:00 2001
+From: Sasha Levin <sashal@kernel.org>
+Date: Wed, 6 Jul 2022 16:40:00 -0700
+Subject: net: Fix data-races around sysctl_mem.
+
+From: Kuniyuki Iwashima <kuniyu@amazon.com>
+
+[ Upstream commit 310731e2f1611d1d13aae237abcf8e66d33345d5 ]
+
+While reading .sysctl_mem, it can be changed concurrently.
+So, we need to add READ_ONCE() to avoid data-races.
+
+Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
+Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
+Signed-off-by: David S. Miller <davem@davemloft.net>
+Signed-off-by: Sasha Levin <sashal@kernel.org>
+---
+ include/net/sock.h | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/include/net/sock.h b/include/net/sock.h
+index 7d3a4c2eea95..98946f90781d 100644
+--- a/include/net/sock.h
++++ b/include/net/sock.h
+@@ -1381,7 +1381,7 @@ void __sk_mem_reclaim(struct sock *sk, int amount);
+ /* sysctl_mem values are in pages, we convert them in SK_MEM_QUANTUM units */
+ static inline long sk_prot_mem_limits(const struct sock *sk, int index)
+ {
+-      long val = sk->sk_prot->sysctl_mem[index];
++      long val = READ_ONCE(sk->sk_prot->sysctl_mem[index]);
+ #if PAGE_SIZE > SK_MEM_QUANTUM
+       val <<= PAGE_SHIFT - SK_MEM_QUANTUM_SHIFT;
+-- 
+2.35.1
+
diff --git a/queue-4.19/seg6-bpf-fix-skb-checksum-in-bpf_push_seg6_encap.patch b/queue-4.19/seg6-bpf-fix-skb-checksum-in-bpf_push_seg6_encap.patch
new file mode 100644 (file)
index 0000000..2b63d21
--- /dev/null
@@ -0,0 +1,44 @@
+From bc56fe02c599f26bc7abae1ae6e6ac198d3752aa Mon Sep 17 00:00:00 2001
+From: Sasha Levin <sashal@kernel.org>
+Date: Tue, 12 Jul 2022 19:58:37 +0200
+Subject: seg6: bpf: fix skb checksum in bpf_push_seg6_encap()
+
+From: Andrea Mayer <andrea.mayer@uniroma2.it>
+
+[ Upstream commit 4889fbd98deaf243c3baadc54e296d71c6af1eb0 ]
+
+Both helper functions bpf_lwt_seg6_action() and bpf_lwt_push_encap() use
+the bpf_push_seg6_encap() to encapsulate the packet in an IPv6 with Segment
+Routing Header (SRH) or insert an SRH between the IPv6 header and the
+payload.
+To achieve this result, such helper functions rely on bpf_push_seg6_encap()
+which, in turn, leverages seg6_do_srh_{encap,inline}() to perform the
+required operation (i.e. encap/inline).
+
+This patch removes the initialization of the IPv6 header payload length
+from bpf_push_seg6_encap(), as it is now handled properly by
+seg6_do_srh_{encap,inline}() to prevent corruption of the skb checksum.
+
+Fixes: fe94cc290f53 ("bpf: Add IPv6 Segment Routing helpers")
+Signed-off-by: Andrea Mayer <andrea.mayer@uniroma2.it>
+Signed-off-by: Paolo Abeni <pabeni@redhat.com>
+Signed-off-by: Sasha Levin <sashal@kernel.org>
+---
+ net/core/filter.c | 1 -
+ 1 file changed, 1 deletion(-)
+
+diff --git a/net/core/filter.c b/net/core/filter.c
+index c1310c9d1b90..5129e89f52bb 100644
+--- a/net/core/filter.c
++++ b/net/core/filter.c
+@@ -4570,7 +4570,6 @@ static int bpf_push_seg6_encap(struct sk_buff *skb, u32 type, void *hdr, u32 len
+       if (err)
+               return err;
+-      ipv6_hdr(skb)->payload_len = htons(skb->len - sizeof(struct ipv6hdr));
+       skb_set_transport_header(skb, sizeof(struct ipv6hdr));
+       return seg6_lookup_nexthop(skb, NULL, 0);
+-- 
+2.35.1
+
diff --git a/queue-4.19/seg6-fix-skb-checksum-evaluation-in-srh-encapsulatio.patch b/queue-4.19/seg6-fix-skb-checksum-evaluation-in-srh-encapsulatio.patch
new file mode 100644 (file)
index 0000000..9e2a817
--- /dev/null
@@ -0,0 +1,73 @@
+From b07b24d089005db9bf31dbc1e0efdc96119a44ac Mon Sep 17 00:00:00 2001
+From: Sasha Levin <sashal@kernel.org>
+Date: Tue, 12 Jul 2022 19:58:35 +0200
+Subject: seg6: fix skb checksum evaluation in SRH encapsulation/insertion
+
+From: Andrea Mayer <andrea.mayer@uniroma2.it>
+
+[ Upstream commit df8386d13ea280d55beee1b95f61a59234a3798b ]
+
+Support for SRH encapsulation and insertion was introduced with
+commit 6c8702c60b88 ("ipv6: sr: add support for SRH encapsulation and
+injection with lwtunnels"), through the seg6_do_srh_encap() and
+seg6_do_srh_inline() functions, respectively.
+The former encapsulates the packet in an outer IPv6 header along with
+the SRH, while the latter inserts the SRH between the IPv6 header and
+the payload. Then, the headers are initialized/updated according to the
+operating mode (i.e., encap/inline).
+Finally, the skb checksum is calculated to reflect the changes applied
+to the headers.
+
+The IPv6 payload length ('payload_len') is not initialized
+within seg6_do_srh_{inline,encap}() but is deferred in seg6_do_srh(), i.e.
+the caller of seg6_do_srh_{inline,encap}().
+However, this operation invalidates the skb checksum, since the
+'payload_len' is updated only after the checksum is evaluated.
+
+To solve this issue, the initialization of the IPv6 payload length is
+moved from seg6_do_srh() directly into the seg6_do_srh_{inline,encap}()
+functions and before the skb checksum update takes place.
+
+Fixes: 6c8702c60b88 ("ipv6: sr: add support for SRH encapsulation and injection with lwtunnels")
+Reported-by: Paolo Abeni <pabeni@redhat.com>
+Link: https://lore.kernel.org/all/20220705190727.69d532417be7438b15404ee1@uniroma2.it
+Signed-off-by: Andrea Mayer <andrea.mayer@uniroma2.it>
+Signed-off-by: Paolo Abeni <pabeni@redhat.com>
+Signed-off-by: Sasha Levin <sashal@kernel.org>
+---
+ net/ipv6/seg6_iptunnel.c | 5 ++++-
+ 1 file changed, 4 insertions(+), 1 deletion(-)
+
+diff --git a/net/ipv6/seg6_iptunnel.c b/net/ipv6/seg6_iptunnel.c
+index 26882fd9323a..2e90672852c8 100644
+--- a/net/ipv6/seg6_iptunnel.c
++++ b/net/ipv6/seg6_iptunnel.c
+@@ -176,6 +176,8 @@ int seg6_do_srh_encap(struct sk_buff *skb, struct ipv6_sr_hdr *osrh, int proto)
+       }
+ #endif
++      hdr->payload_len = htons(skb->len - sizeof(struct ipv6hdr));
++
+       skb_postpush_rcsum(skb, hdr, tot_len);
+       return 0;
+@@ -228,6 +230,8 @@ int seg6_do_srh_inline(struct sk_buff *skb, struct ipv6_sr_hdr *osrh)
+       }
+ #endif
++      hdr->payload_len = htons(skb->len - sizeof(struct ipv6hdr));
++
+       skb_postpush_rcsum(skb, hdr, sizeof(struct ipv6hdr) + hdrlen);
+       return 0;
+@@ -289,7 +293,6 @@ static int seg6_do_srh(struct sk_buff *skb)
+               break;
+       }
+-      ipv6_hdr(skb)->payload_len = htons(skb->len - sizeof(struct ipv6hdr));
+       skb_set_transport_header(skb, sizeof(struct ipv6hdr));
+       return 0;
+-- 
+2.35.1
+
diff --git a/queue-4.19/seg6-fix-skb-checksum-in-srv6-end.b6-and-end.b6.enca.patch b/queue-4.19/seg6-fix-skb-checksum-in-srv6-end.b6-and-end.b6.enca.patch
new file mode 100644 (file)
index 0000000..74cb86d
--- /dev/null
@@ -0,0 +1,51 @@
+From 7d5775f3de1dd0e5cfcc451ab6272b675112f9e8 Mon Sep 17 00:00:00 2001
+From: Sasha Levin <sashal@kernel.org>
+Date: Tue, 12 Jul 2022 19:58:36 +0200
+Subject: seg6: fix skb checksum in SRv6 End.B6 and End.B6.Encaps behaviors
+
+From: Andrea Mayer <andrea.mayer@uniroma2.it>
+
+[ Upstream commit f048880fc77058d864aff5c674af7918b30f312a ]
+
+The SRv6 End.B6 and End.B6.Encaps behaviors rely on functions
+seg6_do_srh_{encap,inline}() to, respectively: i) encapsulate the
+packet within an outer IPv6 header with the specified Segment Routing
+Header (SRH); ii) insert the specified SRH directly after the IPv6
+header of the packet.
+
+This patch removes the initialization of the IPv6 header payload length
+from the input_action_end_b6{_encap}() functions, as it is now handled
+properly by seg6_do_srh_{encap,inline}() to avoid corruption of the skb
+checksum.
+
+Fixes: 140f04c33bbc ("ipv6: sr: implement several seg6local actions")
+Signed-off-by: Andrea Mayer <andrea.mayer@uniroma2.it>
+Signed-off-by: Paolo Abeni <pabeni@redhat.com>
+Signed-off-by: Sasha Levin <sashal@kernel.org>
+---
+ net/ipv6/seg6_local.c | 2 --
+ 1 file changed, 2 deletions(-)
+
+diff --git a/net/ipv6/seg6_local.c b/net/ipv6/seg6_local.c
+index 607709a8847c..18970f6a68c6 100644
+--- a/net/ipv6/seg6_local.c
++++ b/net/ipv6/seg6_local.c
+@@ -415,7 +415,6 @@ static int input_action_end_b6(struct sk_buff *skb, struct seg6_local_lwt *slwt)
+       if (err)
+               goto drop;
+-      ipv6_hdr(skb)->payload_len = htons(skb->len - sizeof(struct ipv6hdr));
+       skb_set_transport_header(skb, sizeof(struct ipv6hdr));
+       seg6_lookup_nexthop(skb, NULL, 0);
+@@ -447,7 +446,6 @@ static int input_action_end_b6_encap(struct sk_buff *skb,
+       if (err)
+               goto drop;
+-      ipv6_hdr(skb)->payload_len = htons(skb->len - sizeof(struct ipv6hdr));
+       skb_set_transport_header(skb, sizeof(struct ipv6hdr));
+       seg6_lookup_nexthop(skb, NULL, 0);
+-- 
+2.35.1
+
index bb488826904297fc518f14ee1ece4f57b565d4c9..c5ffd63c1ced7b5da41cf8e79a49c3e797e1e3d3 100644 (file)
@@ -8,3 +8,19 @@ arm-9213-1-print-message-about-disabled-spectre-workarounds-only-once.patch
 arm-9214-1-alignment-advance-it-state-after-emulating-thumb-instruction.patch
 cgroup-use-separate-src-dst-nodes-when-preloading-css_sets-for-migration.patch
 nilfs2-fix-incorrect-masking-of-permission-flags-for-symlinks.patch
+arm-dts-imx6qdl-ts7970-fix-ngpio-typo-and-count.patch
+arm-9209-1-spectre-bhb-avoid-pr_info-every-time-a-cp.patch
+asoc-sgtl5000-fix-noise-on-shutdown-remove.patch
+inetpeer-fix-data-races-around-sysctl.patch
+net-fix-data-races-around-sysctl_mem.patch
+cipso-fix-data-races-around-sysctl.patch
+icmp-fix-data-races-around-sysctl.patch
+arm-dts-sunxi-fix-spi-nor-campatible-on-orange-pi-ze.patch
+icmp-fix-a-data-race-around-sysctl_icmp_ratelimit.patch
+icmp-fix-a-data-race-around-sysctl_icmp_ratemask.patch
+ipv4-fix-data-races-around-sysctl_ip_dynaddr.patch
+sfc-fix-use-after-free-when-disabling-sriov.patch
+seg6-fix-skb-checksum-evaluation-in-srh-encapsulatio.patch
+seg6-fix-skb-checksum-in-srv6-end.b6-and-end.b6.enca.patch
+seg6-bpf-fix-skb-checksum-in-bpf_push_seg6_encap.patch
+sfc-fix-kernel-panic-when-creating-vf.patch
diff --git a/queue-4.19/sfc-fix-kernel-panic-when-creating-vf.patch b/queue-4.19/sfc-fix-kernel-panic-when-creating-vf.patch
new file mode 100644 (file)
index 0000000..719f2be
--- /dev/null
@@ -0,0 +1,71 @@
+From 7b5e5319b148a783d23d0a20695386f3a6e55522 Mon Sep 17 00:00:00 2001
+From: Sasha Levin <sashal@kernel.org>
+Date: Wed, 13 Jul 2022 11:21:16 +0200
+Subject: sfc: fix kernel panic when creating VF
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+From: Íñigo Huguet <ihuguet@redhat.com>
+
+[ Upstream commit ada74c5539eba06cf8b47d068f92e0b3963a9a6e ]
+
+When creating VFs a kernel panic can happen when calling to
+efx_ef10_try_update_nic_stats_vf.
+
+When releasing a DMA coherent buffer, sometimes, I don't know in what
+specific circumstances, it has to unmap memory with vunmap. It is
+disallowed to do that in IRQ context or with BH disabled. Otherwise, we
+hit this line in vunmap, causing the crash:
+  BUG_ON(in_interrupt());
+
+This patch reenables BH to release the buffer.
+
+Log messages when the bug is hit:
+ kernel BUG at mm/vmalloc.c:2727!
+ invalid opcode: 0000 [#1] PREEMPT SMP NOPTI
+ CPU: 6 PID: 1462 Comm: NetworkManager Kdump: loaded Tainted: G          I      --------- ---  5.14.0-119.el9.x86_64 #1
+ Hardware name: Dell Inc. PowerEdge R740/06WXJT, BIOS 2.8.2 08/27/2020
+ RIP: 0010:vunmap+0x2e/0x30
+ ...skip...
+ Call Trace:
+  __iommu_dma_free+0x96/0x100
+  efx_nic_free_buffer+0x2b/0x40 [sfc]
+  efx_ef10_try_update_nic_stats_vf+0x14a/0x1c0 [sfc]
+  efx_ef10_update_stats_vf+0x18/0x40 [sfc]
+  efx_start_all+0x15e/0x1d0 [sfc]
+  efx_net_open+0x5a/0xe0 [sfc]
+  __dev_open+0xe7/0x1a0
+  __dev_change_flags+0x1d7/0x240
+  dev_change_flags+0x21/0x60
+  ...skip...
+
+Fixes: d778819609a2 ("sfc: DMA the VF stats only when requested")
+Reported-by: Ma Yuying <yuma@redhat.com>
+Signed-off-by: Íñigo Huguet <ihuguet@redhat.com>
+Acked-by: Edward Cree <ecree.xilinx@gmail.com>
+Link: https://lore.kernel.org/r/20220713092116.21238-1-ihuguet@redhat.com
+Signed-off-by: Paolo Abeni <pabeni@redhat.com>
+Signed-off-by: Sasha Levin <sashal@kernel.org>
+---
+ drivers/net/ethernet/sfc/ef10.c | 3 +++
+ 1 file changed, 3 insertions(+)
+
+diff --git a/drivers/net/ethernet/sfc/ef10.c b/drivers/net/ethernet/sfc/ef10.c
+index 6b0a4dc1ced1..5462827d9cbb 100644
+--- a/drivers/net/ethernet/sfc/ef10.c
++++ b/drivers/net/ethernet/sfc/ef10.c
+@@ -2059,7 +2059,10 @@ static int efx_ef10_try_update_nic_stats_vf(struct efx_nic *efx)
+       efx_update_sw_stats(efx, stats);
+ out:
++      /* releasing a DMA coherent buffer with BH disabled can panic */
++      spin_unlock_bh(&efx->stats_lock);
+       efx_nic_free_buffer(efx, &stats_buf);
++      spin_lock_bh(&efx->stats_lock);
+       return rc;
+ }
+-- 
+2.35.1
+
diff --git a/queue-4.19/sfc-fix-use-after-free-when-disabling-sriov.patch b/queue-4.19/sfc-fix-use-after-free-when-disabling-sriov.patch
new file mode 100644 (file)
index 0000000..9172d4d
--- /dev/null
@@ -0,0 +1,113 @@
+From 78fe742062722a100002aca1faeacdad54d9ad47 Mon Sep 17 00:00:00 2001
+From: Sasha Levin <sashal@kernel.org>
+Date: Tue, 12 Jul 2022 08:26:42 +0200
+Subject: sfc: fix use after free when disabling sriov
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+From: Íñigo Huguet <ihuguet@redhat.com>
+
+[ Upstream commit ebe41da5d47ac0fff877e57bd14c54dccf168827 ]
+
+Use after free is detected by kfence when disabling sriov. What was read
+after being freed was vf->pci_dev: it was freed from pci_disable_sriov
+and later read in efx_ef10_sriov_free_vf_vports, called from
+efx_ef10_sriov_free_vf_vswitching.
+
+Set the pointer to NULL at release time to not trying to read it later.
+
+Reproducer and dmesg log (note that kfence doesn't detect it every time):
+$ echo 1 > /sys/class/net/enp65s0f0np0/device/sriov_numvfs
+$ echo 0 > /sys/class/net/enp65s0f0np0/device/sriov_numvfs
+
+ BUG: KFENCE: use-after-free read in efx_ef10_sriov_free_vf_vswitching+0x82/0x170 [sfc]
+
+ Use-after-free read at 0x00000000ff3c1ba5 (in kfence-#224):
+  efx_ef10_sriov_free_vf_vswitching+0x82/0x170 [sfc]
+  efx_ef10_pci_sriov_disable+0x38/0x70 [sfc]
+  efx_pci_sriov_configure+0x24/0x40 [sfc]
+  sriov_numvfs_store+0xfe/0x140
+  kernfs_fop_write_iter+0x11c/0x1b0
+  new_sync_write+0x11f/0x1b0
+  vfs_write+0x1eb/0x280
+  ksys_write+0x5f/0xe0
+  do_syscall_64+0x5c/0x80
+  entry_SYSCALL_64_after_hwframe+0x44/0xae
+
+ kfence-#224: 0x00000000edb8ef95-0x00000000671f5ce1, size=2792, cache=kmalloc-4k
+
+ allocated by task 6771 on cpu 10 at 3137.860196s:
+  pci_alloc_dev+0x21/0x60
+  pci_iov_add_virtfn+0x2a2/0x320
+  sriov_enable+0x212/0x3e0
+  efx_ef10_sriov_configure+0x67/0x80 [sfc]
+  efx_pci_sriov_configure+0x24/0x40 [sfc]
+  sriov_numvfs_store+0xba/0x140
+  kernfs_fop_write_iter+0x11c/0x1b0
+  new_sync_write+0x11f/0x1b0
+  vfs_write+0x1eb/0x280
+  ksys_write+0x5f/0xe0
+  do_syscall_64+0x5c/0x80
+  entry_SYSCALL_64_after_hwframe+0x44/0xae
+
+ freed by task 6771 on cpu 12 at 3170.991309s:
+  device_release+0x34/0x90
+  kobject_cleanup+0x3a/0x130
+  pci_iov_remove_virtfn+0xd9/0x120
+  sriov_disable+0x30/0xe0
+  efx_ef10_pci_sriov_disable+0x57/0x70 [sfc]
+  efx_pci_sriov_configure+0x24/0x40 [sfc]
+  sriov_numvfs_store+0xfe/0x140
+  kernfs_fop_write_iter+0x11c/0x1b0
+  new_sync_write+0x11f/0x1b0
+  vfs_write+0x1eb/0x280
+  ksys_write+0x5f/0xe0
+  do_syscall_64+0x5c/0x80
+  entry_SYSCALL_64_after_hwframe+0x44/0xae
+
+Fixes: 3c5eb87605e85 ("sfc: create vports for VFs and assign random MAC addresses")
+Reported-by: Yanghang Liu <yanghliu@redhat.com>
+Signed-off-by: Íñigo Huguet <ihuguet@redhat.com>
+Acked-by: Martin Habets <habetsm.xilinx@gmail.com>
+Link: https://lore.kernel.org/r/20220712062642.6915-1-ihuguet@redhat.com
+Signed-off-by: Jakub Kicinski <kuba@kernel.org>
+Signed-off-by: Sasha Levin <sashal@kernel.org>
+---
+ drivers/net/ethernet/sfc/ef10_sriov.c | 10 +++++++---
+ 1 file changed, 7 insertions(+), 3 deletions(-)
+
+diff --git a/drivers/net/ethernet/sfc/ef10_sriov.c b/drivers/net/ethernet/sfc/ef10_sriov.c
+index f074986a13b1..fc3cb26f7112 100644
+--- a/drivers/net/ethernet/sfc/ef10_sriov.c
++++ b/drivers/net/ethernet/sfc/ef10_sriov.c
+@@ -415,8 +415,9 @@ static int efx_ef10_pci_sriov_enable(struct efx_nic *efx, int num_vfs)
+ static int efx_ef10_pci_sriov_disable(struct efx_nic *efx, bool force)
+ {
+       struct pci_dev *dev = efx->pci_dev;
++      struct efx_ef10_nic_data *nic_data = efx->nic_data;
+       unsigned int vfs_assigned = pci_vfs_assigned(dev);
+-      int rc = 0;
++      int i, rc = 0;
+       if (vfs_assigned && !force) {
+               netif_info(efx, drv, efx->net_dev, "VFs are assigned to guests; "
+@@ -424,10 +425,13 @@ static int efx_ef10_pci_sriov_disable(struct efx_nic *efx, bool force)
+               return -EBUSY;
+       }
+-      if (!vfs_assigned)
++      if (!vfs_assigned) {
++              for (i = 0; i < efx->vf_count; i++)
++                      nic_data->vf[i].pci_dev = NULL;
+               pci_disable_sriov(dev);
+-      else
++      } else {
+               rc = -EBUSY;
++      }
+       efx_ef10_sriov_free_vf_vswitching(efx);
+       efx->vf_count = 0;
+-- 
+2.35.1
+