]> git.ipfire.org Git - thirdparty/qemu.git/commitdiff
hw/core/loader: fix error handling for get_image_size callers
authorTrieu Huynh <vikingtc4@gmail.com>
Wed, 18 Mar 2026 14:14:11 +0000 (23:14 +0900)
committerPhilippe Mathieu-Daudé <philmd@linaro.org>
Mon, 23 Mar 2026 13:54:13 +0000 (14:54 +0100)
Check the return value of get_image_size() and report failures
for non-mandatory file such as FRU image.

- Use ret < 0 to detect failures in getting image size.
- No functional changes.

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/413
Signed-off-by: Trieu Huynh <vikingtc4@gmail.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Message-ID: <20260318141415.8538-3-vikingtc4@gmail.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
hw/ipmi/ipmi_bmc_sim.c

index 012e2ee4fe23692246c11654502b3dfa2a6d6283..fd875491f558c11fac95dcf4bb340a937c253c04 100644 (file)
@@ -2561,6 +2561,8 @@ static void ipmi_fru_init(IPMIFru *fru)
             g_free(fru->data);
             fru->data = NULL;
         }
+    } else {
+        error_report("Could not get file size '%s'", fru->filename);
     }
 
 out: