]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
[3.11] Improve test coverage for is_typeddict (GH-104884) (#104888)
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Wed, 24 May 2023 19:23:35 +0000 (12:23 -0700)
committerGitHub <noreply@github.com>
Wed, 24 May 2023 19:23:35 +0000 (19:23 +0000)
In particular, it's important to test that is_typeddict(TypedDict)
returns False.
(cherry picked from commit 1497607a8e99f1103c40368dd5f9057f0146a520)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Lib/test/test_typing.py

index e36cab601621e3783656a4053caef28d77e1d1f5..5cb4356a8c69a6266581fac3fd49cbde46a13aad 100644 (file)
@@ -6756,10 +6756,23 @@ class TypedDictTests(BaseTestCase):
                         pass
 
     def test_is_typeddict(self):
-        assert is_typeddict(Point2D) is True
-        assert is_typeddict(Union[str, int]) is False
+        self.assertIs(is_typeddict(Point2D), True)
+        self.assertIs(is_typeddict(Union[str, int]), False)
         # classes, not instances
-        assert is_typeddict(Point2D()) is False
+        self.assertIs(is_typeddict(Point2D()), False)
+        call_based = TypedDict('call_based', {'a': int})
+        self.assertIs(is_typeddict(call_based), True)
+        self.assertIs(is_typeddict(call_based()), False)
+
+        T = TypeVar("T")
+        class BarGeneric(TypedDict, Generic[T]):
+            a: T
+        self.assertIs(is_typeddict(BarGeneric), True)
+        self.assertIs(is_typeddict(BarGeneric[int]), False)
+        self.assertIs(is_typeddict(BarGeneric()), False)
+
+        # The TypedDict constructor is not itself a TypedDict
+        self.assertIs(is_typeddict(TypedDict), False)
 
     def test_get_type_hints(self):
         self.assertEqual(