]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
gh-75367: Fix data descriptor detection in inspect.getattr_static (#104517)
authorFurkan Onder <furkanonder@protonmail.com>
Tue, 16 May 2023 17:34:44 +0000 (17:34 +0000)
committerGitHub <noreply@github.com>
Tue, 16 May 2023 17:34:44 +0000 (17:34 +0000)
Co-authored-by: Carl Meyer <carl@oddbird.net>
Lib/inspect.py
Lib/test/test_inspect.py
Misc/NEWS.d/next/Library/2023-05-16-11-02-44.gh-issue-75367.qLWR35.rst [new file with mode: 0644]

index a64e85e4fd67a45db1260028ef34e308c0772066..63f5aa91d270b74e85643d136effb552c26a9780 100644 (file)
@@ -1835,8 +1835,10 @@ def getattr_static(obj, attr, default=_sentinel):
     klass_result = _check_class(klass, attr)
 
     if instance_result is not _sentinel and klass_result is not _sentinel:
-        if (_check_class(type(klass_result), '__get__') is not _sentinel and
-            _check_class(type(klass_result), '__set__') is not _sentinel):
+        if _check_class(type(klass_result), "__get__") is not _sentinel and (
+            _check_class(type(klass_result), "__set__") is not _sentinel
+            or _check_class(type(klass_result), "__delete__") is not _sentinel
+        ):
             return klass_result
 
     if instance_result is not _sentinel:
index 364f75db908b05d02b65306f7bed99d618976cd6..0590e49d0e1a431f808cd0431619617e25ca9dc3 100644 (file)
@@ -2052,6 +2052,9 @@ class TestGetattrStatic(unittest.TestCase):
         descriptor.__set__ = lambda s, i, v: None
         self.assertEqual(inspect.getattr_static(foo, 'd'), Foo.__dict__['d'])
 
+        del descriptor.__set__
+        descriptor.__delete__ = lambda s, i, o: None
+        self.assertEqual(inspect.getattr_static(foo, 'd'), Foo.__dict__['d'])
 
     def test_metaclass_with_descriptor(self):
         class descriptor(object):
diff --git a/Misc/NEWS.d/next/Library/2023-05-16-11-02-44.gh-issue-75367.qLWR35.rst b/Misc/NEWS.d/next/Library/2023-05-16-11-02-44.gh-issue-75367.qLWR35.rst
new file mode 100644 (file)
index 0000000..554c425
--- /dev/null
@@ -0,0 +1 @@
+Fix data descriptor detection in  :func:`inspect.getattr_static`.