build: Add `make clippy` option for Rust linting.

Note that clippy is quite loud/obnoxious, as its name would imply.
This target isn't meant to run on CI, or even necessarily exit
cleanly.  It's merely a way for developers to check if they've made
any glaring mistakes, or done awkward things they might not have
otherwise realised.  We *can* configure it to be quieter in the
future, but it's probably not worth rabbitholing on.

 * CLOSES #22156: https://bugs.torproject.org/22156

diff --git a/Makefile.am b/Makefile.am
index 58ff9fb3e8505391808020bfb38fc23ad26b5824..c533f577b31c042876495f725cc690e5df1f937c 100644 (file)
--- a/Makefile.am
+++ b/Makefile.am
@@ -238,6 +238,20 @@ check-typos:
                echo "You can install the latest version of misspell here: https://github.com/client9/misspell#install"; \
        fi
 
+.PHONY: clippy
+clippy:
+if USE_RUST
+       @if test -x "`which cargo-clippy 2>&1;true`"; then \
+               echo "Running cargo clippy ..."; \
+               echo "Prepare yourself for the onslaught of suggestions ..."; \
+               (cd "$(top_srcdir)/src/rust" && cargo clippy); \
+       else \
+               echo "Tor can use clippy to lint Rust code."; \
+               echo "However, it seems that you don't have clippy installed."; \
+               echo "You can install the latest version of clippy by following the directions here: https://github.com/rust-lang-nursery/rust-clippy"; \
+       fi
+endif
+
 .PHONY: check-changes
 check-changes:
 if USEPYTHON