]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
bpo-45406: make inspect.getmodule() return None when getabsfile() raises FileNotFound...
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Tue, 2 Nov 2021 22:26:40 +0000 (15:26 -0700)
committerGitHub <noreply@github.com>
Tue, 2 Nov 2021 22:26:40 +0000 (15:26 -0700)
(cherry picked from commit a459a81530de700b3d3faeb827b22ed1c9985812)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
Lib/inspect.py
Lib/test/test_inspect.py
Misc/NEWS.d/next/Library/2021-10-08-19-24-48.bpo-45406.Qh_Mz4.rst [new file with mode: 0644]

index 64605c3cd3f6f381d8a8245ec158d0e26e7caf06..10b5d14eb37bf5c3d80f212ff6e5761ad31001d1 100644 (file)
@@ -736,7 +736,7 @@ def getmodule(object, _filename=None):
     # Try the cache again with the absolute file name
     try:
         file = getabsfile(object, _filename)
-    except TypeError:
+    except (TypeError, FileNotFoundError):
         return None
     if file in modulesbyfile:
         return sys.modules.get(modulesbyfile[file])
index 8a8844e912ad21ba0b6740422a44fcfccb067b0c..08aed248b96652118e46dccbc5921aa4b32ff4ab 100644 (file)
@@ -488,6 +488,15 @@ class TestRetrievingSourceCode(GetSourceBase):
         # Check filename override
         self.assertEqual(inspect.getmodule(None, modfile), mod)
 
+    def test_getmodule_file_not_found(self):
+        # See bpo-45406
+        def _getabsfile(obj, _filename):
+            raise FileNotFoundError('bad file')
+        with unittest.mock.patch('inspect.getabsfile', _getabsfile):
+            f = inspect.currentframe()
+            self.assertIsNone(inspect.getmodule(f))
+            inspect.getouterframes(f)  # smoke test
+
     def test_getframeinfo_get_first_line(self):
         frame_info = inspect.getframeinfo(self.fodderModule.fr, 50)
         self.assertEqual(frame_info.code_context[0], "# line 1\n")
diff --git a/Misc/NEWS.d/next/Library/2021-10-08-19-24-48.bpo-45406.Qh_Mz4.rst b/Misc/NEWS.d/next/Library/2021-10-08-19-24-48.bpo-45406.Qh_Mz4.rst
new file mode 100644 (file)
index 0000000..2c3a816
--- /dev/null
@@ -0,0 +1 @@
+Make :func:`inspect.getmodule` catch ``FileNotFoundError`` raised by  :'func:`inspect.getabsfile`, and return ``None`` to indicate that the module could not be determined.
\ No newline at end of file